Add the Gothic and Karaoke genre icons

[jrbastien]

While testing the position of the genre icon, I have changed some of my songs genre to get the icons from the 4th column and found that the Gothic genre (Vicking hat icon) and Karaoke genre (microphone, monitor and speaker icon) were missing.

[fossfreedom]

very weird - both of those are visible to me :/

Any errors you see if you launch rhythmbox from the terminal?

[jrbastien]

Not much. The same message when it is a recognized genre:

(20:38:33) [0x1d01490] [CoverArtBrowserSource.update_iconview_callback] .local/share/rhythmbox/plugins/coverart_browser/coverart_browser_source.py:1310: CoverArtBrowser DEBUG - update_iconview_callback

I think I know what is happening. RB is not updating the tag but its local database. If I go to my other system, the track has still the previous genre.

To reproduce, take an album that you have in your collection, expand the track listing, Right-click on a genre, select property and update the genre to "Gothic".

See track 1 of this album:

[fossfreedom]

"Gothic" is not a recognised genre - the viking helmet symbol is mapped to "opera" according to popups.xml.

When I change "Gothic" to "Opera" and then change the genre button to "Opera" - the helmet symbol is shown.

I think you are correct - the ID3 tags are not altered by rhythmbox - it holds its genres separately in its own external database - it reads the genre from the track when it is first loaded and stores this in its database. Thereafter, the changes are done to its own database.

Might be an interesting plugin to write - but is really out-of-scope for this plugin (probably).

Lots of genre icons here - https://github.com/stoli/Metropolis/tree/master/media/musicgenres

however not really button compatible and not on a spritesheet :(

EDIT:

I saw there as a typo in the popups.xml for "karaoke" - this has now been corrected.

[jrbastien]

OK, I had a misconception of the Gothic genre. Since it is an alternative genre of music, could we use the same icon?

Also, I just noticed this in popups.xml: ... <genre name="world" spritesheet="genre"/> ... <alt genre="rock">world beat</alt>

I think it is a mistake. Luckily the code seems to take the first matching world and display the right icon for my library.

For the Karaoke genre, I confirm that it is fixed.

[fossfreedom]

There you go :)

[jrbastien]

Thank you. The way popups.xml works I see some possibility for other language support but this is for another issue!