Cover position changing when playing

[jrbastien]

Here is a bizarre issue. If you have let's say 5 albums from a certain artists and your sort is set by album artists, when you play the album, its position shifts to the first album by this artist.

I have also seen this problem when sorting by year. It also shifts to a different position within the same year.

[asermax]

I think I know where the problem is, gonna check it out.

[asermax]

I had some problems trying to fix this. First, I tried ignoring some signals that caused this reordering (when a track is played, some of it's details are updated and our plugin catches this signals and tries to udpate the album). But for some reason, rhythmbox does not correctly inform the property that got modified, and that made it difficult to differentiate between useful properties and unneeded ones (e.g. genre, which is important to apply the genre filter; and play count that isn't really necesary, and causes an unnecesary reordering). So far, I hadn't figured out how to differentiate between those, so that was a dead end. Then I decided to do some extra work on the low level implementation of the sorted collection that keeps the albums in order. Made some amendments on how the album gets reordered when something changes, so the collection would conserve the old position in the case there is no need for reorder. In fact, I killed two birds with one stone:

• The bug mentioned in this issue is no longer present.
• Before this fix, when updating some property (related or no not with the current sorting key) the album would get reordered in the same fashion as described here; now this doesn't happen anymore.

Still, I made little testing on the changes, so it would be very appreciated if you could test it further to see if I introduced any other problem. Let me know either way :3

[jrbastien]

That works for me. Thank you.