Patch 2 - Additional genres and French translations

[jrbastien]

Here are some additional genres alternate mapping.

Looking @londumas' list of genres, I realized that not everybody have their genres set to English. So I modified popups.xml to provide basic French translation.

Do you think it is the place to do it? Also, does it support unicode? For the "e" with an accent, I tried to input & e a c u t e ; like you have done on R and B, but that did not work.

EDIT: Please correct the world "accoustique" (should be "accoustic" in the alternate English section and lower case the "H" on "House".

[fossfreedom]

@jrbastien - I think there should be either language specific sections within popups.xml or separate locale variants of popups.xml - for example "popups.fr_ca.xml". We need to have the benefit of language specific stuff - but with a fall-back for those that have their music categorised in english.

I'm in two minds on the best approach ... let me have a think on the practicalities of each approach.

If you have any thoughts, just drop a comment.

[jrbastien]

It all depends if you intend to implement more evolved skins in the future. Then it would make sense to have a dedicated popups.xml file. For now, a comment in the file like I have done would suffice. Especially that not all the genres need translation. For instance Rock is universal.

Performance is another consideration.

[fossfreedom]

@jrbastien - I've merged where I can. I've captured as much as I can.

Looking at the results there are 48 translations left to do on the fr_CA.po

N.B. translation is now done on Launchpad.net

• https://translations.launchpad.net/coverartbrowser/trunk

[jrbastien]

I'm quite confused here. I had made all the translation to fr_CA.po before. How can the genres be translated since they come directly from the music files tags? The idea was to add genres like "opéra" to popups.xml and map it to "opera" so it can display the proper icon.

What have you merged exactly?

[fossfreedom]

ok - what is going to happen is that there is going to be one file - popups.xml.

This will be a system generated file containing all translations. A translator will update just the one file (for example fr_CA.po). Thus a translator needs to only worry about one file rather than two or more translation files.

This PO file will have the locale translations for the normal genres such as "opera" (or whatever it is called) - the translator then adds the equivalent translation - e.g. "opéra".

It is intended to use both the english and locale values to display the correct icon.

Thus you can have music with genres both in english and french-CA and it will find the correct icon for you i.e. if the album genre is "opéra" then it will use the translation file to find the correct icon. If the album genre is "opera" then it will look in the common file and find the same icon.

If there is additional alternative genres then this goes directly in the popups file. It will operate the same way - there will be a locale specific section and a common "english" variants.

The master file is now going to be called "popups.xml.in" and when installing the coverart-browser it will generate "popups.xml" from all the locales.

I've added most of the alternatives you gave in the french section of the new popups file. Some of them I have moved into the common section since I know they equally apply.

The other translations I have added to fr_CA.po - this is now on Launchpad (link above).

If you dont want to use Launchpad (trust me its easier to do it this way) - then let me know - I'll copy the file from Launchpad into the project source code here on GitHub.

[jrbastien]

Wow, this is brilliant. I will give it a try. No problem, I can use Launchpad.

[londumas]

I am doing the translation. But I am realy not sure it is very interesting for French from France because we keep English names most of the time.

I think also that there is a mistake. For "20's", there is an information saying: "'20s' as in the decade 2020", it may be 1920, no?

[jrbastien]

@londumas, I have realigned some of my French Canadian translation to yours et noticed that you have confused Playlist for a "liste d'attente". In RB, there are playlist and play queue. These are 2 different things.

I took the liberty to fix it directly on Launchpad.

And no, the 20s will be used if this plugins lasts up to 2020!

[jrbastien]

@fossfreedom, I'm testing right now the master branch with my updated translations and see no difference. If I rename the genre of one my songs from "Opera" to "Opéra", a new genre "Opéra" gets added to the list and its icon shows the unknown genre (music headset).

Also the decades (10s, 00s, etc...) don't get translated.

[fossfreedom]

@jrbastien - thanks for the translation. I'll use what you have done and drag it to my branch to test with. Once done, I'll push up the branch to GitHub for you to confirm all is OK.

BTW - its a controlled process - Launchpad is updated. I'll sign-off the changes and transfer it to GitHub to be incorporated.

[londumas]

I have nearly finished the translation but I don't know what that is "musical", "workout" and "default". I went to Wikipedia English but they don't speak about it. Is musical, the kind of music of theatre, like Broadway?

[fossfreedom]

@londumas - musical - yes just like Broadway musicals - Les Misérables etc workout are those exercise fitness videos you probably see being advertised each New Year on TV.

default is probably a mistake - I dont think this should be translated. I'll remove this from the list to be translated tonight.

[jrbastien]

@londumas, if you select Français (Canada) in your preferred languages in Launchpad, you will see how it was translated in this language.

In the case of "musical", I suggest that you use the genre that is the most likely for France (like the genre you would associate to Notre-Dame de Paris for instance), not necessary musical. This way, more people in France will see the icon instead of getting a standard unrecognized genre.

[londumas]

ok thanks, I will do that

[londumas]

I have some questions for you @fossfreedom why did you translate "pop" by "pop française"? There can be English pop no? Why "oldies" by "cabaret"? Cabaret is like Moulin rouge and "oldies" is something 15-20 years old. (wikipedia). "holiday" by "noël", there are other holidays in the year, no? I changed the translation of "gospel" from "musique religieuse" by "gospel" because in France, the fist would refere more of something very quiet of monks and the second to something like the "Sister Act" movie.

@jrbastien I changed "musical" into "comédie musicale" because I think you made a typing error in the French-Ca translation.

[fossfreedom]

@londumas - those were taken from @jrbastien translation for fr_CA - if you feel they are not relevant for the general French public - you can change them.

I note your comment about France in general use english for their genres - in that case - a direct french translation is probably not appropriate - may be just make the suggestion to use the same english name.

@asermax - looks like from the launchpad website the spanish version is now close to completion - someone has taken up that particular challenge. Also I note a Finnish (Finland) being developed. Looks like the plugin is going truly global :)

[jrbastien]

To answer @londumas, "pop française" is a genre provided in the latest itunes version. I have tried to cover them all in my translations.

I originally did not provide translations but genre mapping. I kept "pop française" in the French Canadian PO because it will provide an additional mapping to "pop". I agree that most people will only have "pop" genre. My understanding is that the plugin will not translate the genre if it is in the original list in English.

[asermax]

@fossfreedom Nice! I was wondering when I would do the translation myslef, but if there's someone else to help is much better xD I can concentrate on the code then d: