fossfreedom / coverart-browser

Browse your cover-art albums in Rhythmbox v2.96 - 3.0+
http://xpressubuntu.wordpress.com/
GNU General Public License v3.0
74 stars 19 forks source link

Bug: Double click of covers pane occasionally does not update the cover #135

Closed fossfreedom closed 11 years ago

fossfreedom commented 11 years ago

Drag and drop seems to always work.

However, on some double click of a cover in the CoverSearchPane produces the following output:

Traceback (most recent call last):
  File "/usr/lib/rhythmbox/plugins/rb/Loader.py", line 33, in callback_with_gdk_lock
    v = callback(data, *args)
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_browser/coverart_album.py", line 1424, in cover_update
    tmp.write(data)
TypeError: expected a character buffer object

Putting in trace events, it looks like the tmp.write(data) in coverart_album is failing - data is None.

Other stuff I noted - the CoverSearchPane inherits from Gtk.VBox - this is deprecated.

EDIT - looks like some URIs coverart_search.set_cover looks like this: http://s3.amazonaws.com/dfree/warehouse/album_art/ec9bd7a8-b4e6-11e1-bc77-1231381d7f9f.jpg%3F1339544062

The % stuff is spurious - trim this somehow? is all URI's ending in .jpg ?