fossfreedom / coverart-browser

Browse your cover-art albums in Rhythmbox v2.96 - 3.0+
http://xpressubuntu.wordpress.com/
GNU General Public License v3.0
74 stars 19 forks source link

Enhancement - Auto ellipsize icon labels #157

Closed fossfreedom closed 11 years ago

fossfreedom commented 11 years ago

Just noticed this - now we've got the cellrenderertext stuff in coverart_album we could use

&

and set the ellipsize_set = True & ellipsize = 3 properties so that ellipsize automatically takes place.

This would remove the need to calculate the ellipsize stuff ourselves.

EDIT: CellTextRenderer in coverart_album.py requires the following for autoellipsize

self._text_renderer.props.ellipsize_set = True self._text_renderer.props.ellipsize = 3

Doing this though will need to pad out slightly the space between icons (vertically) since the ellipsize character slightly affects this and visually the text is slightly hidden

@asermax - do you see any issues with this?

If not - I'll crack on and do this, removing the calculation stuff and the setting the number of characters stuff in the preferences window.

asermax commented 11 years ago

I tried it myself when playing with the cellrenderer and didn't like the result, the ellipsis are extrangelly large (like instead of using dots, it uses some different utf character). The calculations aren't really expensive, and are done only once, so I don't think it would have any performance overhead.

Said that, you can do whatever you want with it xD feel free to implement it if you want. Still, I don't see this as a priority tho.

fossfreedom commented 11 years ago

superfluous