search

fossfreedom / coverart-browser

Browse your cover-art albums in Rhythmbox v2.96 - 3.0+
http://xpressubuntu.wordpress.com/
GNU General Public License v3.0
74 stars 19 forks source link

Bug: Multi-disc releases have tracks added to play queue in wrong order #160

Closed hdave closed 11 years ago

hdave commented 11 years ago

Say you have a 2 or 3 cd release. When you click on the album cover art and select "Play Album" or "Queue Album" the tracks get added but like this:

CD 1 - Track 1 CD 2 - Track 1 CD 3 - Track 1 CD 1 - Track 2 CD 2 - Track 2 CD 3 - Track 2 CD 1 - Track 3 CD 2 - Track 3 CD 3 - Track 3

Instead of:

CD 1 - Track 1 CD 1 - Track 2 CD 1 - Track 3 CD 2 - Track 1 CD 2 - Track 2 CD 2 - Track 3 CD 3 - Track 1 CD 3 - Track 2 CD 3 - Track 3

Hope this helps. Thanks for a great plugin.

fossfreedom commented 11 years ago

When you right click your albums and choose properties - do you have the "Album Artist" field filled with an entry - or is it blank?

Since its is an album view - we need this info filled. Can you clarify this please?

hdave commented 11 years ago

Yes - I have "album artist" tag populated. All of the tracks for all of the CD are located under this one "Album". There is a tag called "Disc Number" that needs to be included in the sort order for tracks being added to the play queue.

fossfreedom commented 11 years ago

@hdave - please can you post a link to a screen-shot with the track-view open - I need to see the track names and track numbers for the album that has this issue.

cheers.

hdave commented 11 years ago

Here is a picture of the track order I got when adding to the play queue in coverart browser. Note that "Act IV: Symphony" is the first track on the second CD.

https://dl.dropbox.com/u/3891104/play%20queue%20for%20purcell%20fairy%20queen.png

And here is the picture of the tracks in regular rythmbox...even though I have sorted by the "Track" column, Rhythmbox does the Right Thing. You can also see via the properties window that the Disc Number is set correctly.

https://dl.dropbox.com/u/3891104/track%20order%20in%20vanilla%20rb.png

fossfreedom commented 11 years ago

hmmm ... thanks for the info - any chance you can email me the first 3 or 4 tracks so that I can see myself how rhythmbox sorts these? This will help me debug this.

hdave commented 11 years ago

Not sure what your email is...and these are large FLAC files anyway...so here are the links:

https://dl.dropbox.com/u/3891104/purcell/1-01%20First%20Musick_%20Prelude.flac https://dl.dropbox.com/u/3891104/purcell/1-02%20First%20Musick_%20Hornpipe.flac https://dl.dropbox.com/u/3891104/purcell/1-03%20Second%20Musick_%20Air.flac https://dl.dropbox.com/u/3891104/purcell/2-01%20Act%204_%20Symphony.flac https://dl.dropbox.com/u/3891104/purcell/2-02%20Act%204_%20An%20Attendant%2C%20Chorus_%20Now%20the%20night%20is%20chased%20away.flac https://dl.dropbox.com/u/3891104/purcell/2-03%20Act%204_%20Duet_%20Let%20the%20fifes%20and%20the%20clarions.flac

fossfreedom commented 11 years ago

@hdave - thanks for this.

I've committed a change that will hopefully fix this.

Please can you test this out?

Installation instructions as per:

please purge the deb package rhythmbox-plugin-coverart-browser first if you have this installed from my PPA.

hdave commented 11 years ago

@fossfreedom - Thanks for the fix. I'm out for the next week and a half, and can't test it. I have your PPA installed...feel like just releasing it?

fossfreedom commented 11 years ago

Its fixed on the master branch - I'm not intending to backport this into v0.7 - thus the fix will not be released in PPA form until April/May (i.e. for release 0.8)

There is no hurry on testing this. Its seems to work for me.

I'll close this for now - with the assumption its fixed for you. Drop a comment here when you get time to confirm if its not resolved.