fossfreedom / coverart-browser

Browse your cover-art albums in Rhythmbox v2.96 - 3.0+
http://xpressubuntu.wordpress.com/
GNU General Public License v3.0
74 stars 19 forks source link

RB2.99: Unable to load pluging using latest build #191

Closed ernesto1 closed 11 years ago

ernesto1 commented 11 years ago

Fedora 19 install with RB2.99 The pluging does not load upon startup, I get the following error:

File "/home/ernesto/.local/share/rhythmbox/plugins/coverart_browser/coverart_browser.py", line 108, in do_activate query_model=self.shell.props.library_source.props.base_query_model) File "/home/ernesto/.local/share/rhythmbox/plugins/coverart_browser/coverart_browser_source.py", line 68, in __init__ super(CoverArtBrowserSource, self).__init__(**kargs) File "/usr/lib64/python2.7/site-packages/gi/overrides/Gtk.py", line 332, in __init__ super(Box, self).__init__(**kwds) TypeError: gobjectcoverart_browser_source+CoverArtBrowserSource' doesn't support property icon'

After I close rhythmbox I get the additional trace:

Traceback (most recent call last): File "/home/ernesto/.local/share/rhythmbox/plugins/coverart_browser/coverart_browser.py", line 134, in do_deactivate self.source.delete_thyself() AttributeError: 'CoverArtBrowserPlugin' object has no attribute 'source'

fossfreedom commented 11 years ago

Thanks for testing - please let me know if the above fix resolves this. Cheers.

ernesto1 commented 11 years ago

It did. I'm able to view the covers now.

However I don't have the search bar anymore that came with your pluging or the default RB one for that matter. I tried enabling/disabling 'Use source custom status bar' under the General tab to see if that would be it, but no dice.

Perhaps this trace helps:

Traceback (most recent call last): File "/home/ernesto/.local/share/rhythmbox/plugins/coverart_browser/coverart_widgets.py", line 1013, in selectionchanged_callback self.source.update_with_selection() File "/home/ernesto/.local/share/rhythmbox/plugins/coverart_browser/coverart_browser_source.py", line 724, in update_with_selection self.statusbar.emit('display-status', self.current_view) AttributeError: 'CoverArtBrowserSource' object has no attribute 'statusbar'

fossfreedom commented 11 years ago

I'm not sure about the above error - but I suspect it is a result of the playlist changes in RB2.99 and where this crashed, the rest of the code did not successfully execute.

I've made an interim fix for the playlist crash - I've raised another issue to track the remaining playlist problem in RB2.99.

Give it another go.

Thanks for testing this - its invaluable - especially with the extensive changes that have been made, and additional changes still to come as the coverflow view is fully developed and integrated.

mjog commented 11 years ago

Current master (dcc89ed8a2) fails to load on 2.99.1 (Ubuntu Raring + GNOME3 PPA) with the following error:

(rhythmbox:8320): libpeas-WARNING **: Could not find loader 'python3' for plugin 'coverart_browser'

Rewinding to b6bb7ea (i.e. the fix for this) works fine however.

fossfreedom commented 11 years ago

@mjog - my oops - I was doing some checks on the Git version of RB which requires python3 and accidently checked in the changed coverart-browser.plugin file. I've corrected the plugin file to use "python" not "python3".

In the longer term - the install.sh needs to change to cope with both python and python3.

ernesto1 commented 11 years ago

@fossfreedom, I'm happy to help with the testing. I'm starting to get my feet wet in the FOSS world.

I'm happy to report that the latest commits have fixed my problems so far:

WIll report any other issues if I encounter any during my daily usage.