search

fossfreedom / coverart-browser

Browse your cover-art albums in Rhythmbox v2.96 - 3.0+
http://xpressubuntu.wordpress.com/
GNU General Public License v3.0
74 stars 19 forks source link

v0.9 translation issues #202

Closed fossfreedom closed 11 years ago

fossfreedom commented 11 years ago

raise one global issue to cover all translation issues for this release.

  1. to-do. Rerun the capture of new translation strings and upload to launchpad
  2. Noticed that the filter message at the top of the coverflow display (when more than the allotted albums cannot all be displayed) cannot be translated. Need to move this to a translatable area in the code-base.
fossfreedom commented 11 years ago

this commit covers 1 - https://github.com/fossfreedom/coverart-browser/commit/e7b68f91b7d99bc2c31918d1a18f9a57b3652dc6

issue 2 covered elsewhere. Just need to upload to launchpad at a couple of weeks before release.

fossfreedom commented 11 years ago

@jrbastien

if its not too much trouble, can I call on you to update the French-Canadian locale on launchpad?

I've uploaded the v0.9 translations - there is approximately 32 new translation strings to be done. Once done, then it will be possible to test to confirm that all the v0.9 functionality works correctly with different languages.

thanks in advance

jrbastien commented 11 years ago

I'm sorry. I'm on vacation until August 16th with limited time for this and a very bad internet connection. I hope it can wait until then. If not, I suggest that you use the translations from my French counterpart on the other side of the Atlantic (londumas). I will review upon my return.

fossfreedom commented 11 years ago

@jrbastien - hey, no worries - have a great time on your vacation :-D

@londumas - re the above - if you are not equally on vacation ... and have some free time available, could you complete the french locale on launchpad please?

londumas commented 11 years ago

Yes I will do what I can.

jrbastien commented 11 years ago

Hello, I'm back from vacation. I have completed the translations and also have some observations:

  1. What does "Tile" refer to exactly? The view or the mode? Would it be more accurate to refer to "Tiles" plural?
  2. I have been playing with the Padding and spacing options to understand how to translate them but I can't find the difference between the 2 options. Reducing or increasing the value seems to produce the same result in my case.
  3. I can't get the tooltip for the spacing option. It is in the translation on Launchpad but not displaying on my system.
  4. The translations for both the light source and toolbar position are gone. (eg. Above cover view, Left and Right sidebar, above, top left, top right top center)
  5. For consistency the "w" in "width (px)" should be capitalized.
  6. What does translation number 153 "All" refer to? This is needed in French for the proper gender.
  7. The search box is no longer wide enough to translate ""Search all fields" to "Rechercher tous les champs".
fossfreedom commented 11 years ago

@jrbastien - welcome back. Hope you had a relaxing vacation. Cheers for looking at this so soon on your return.

  1. This is the view - the text of the view button. I've changed this to "Tiles" as requested
  2. The differences are subtle but they are separate - if you highlight one of the tile covers then reduce the spacing you'll notice the highlight remains the same. If you instead reduce the padding you'll notice the highlight shrinks. It is particularly noticeable if you dont use the shadow options.
  3. The tooltip was mistakenly on the spacing label - I've moved this to the spinbutton - good spot!
  4. regenerated translations - should be ok now hopefully
  5. agreed - now capitalized
  6. added a translator tip (should now be visible in launchpad) "TRANSLATORS - "All" is used in the context of "All artist names"
  7. not sure on this one - will investigate further

I've uploaded a new translation file to launchpad.

I've also pulled your fr_CA translation into the source repository.

jrbastien commented 11 years ago
  1. Fixed
  2. Very subtle indeed! In the tool tip when it says "Padding (space) around each icon", you mean the highlight + the cover. Is this what you designate by the word icon? Perhaps we should use this instead: "Padding (space) around the cover and its highlight".
  3. Fixed
  4. Fixed
  5. Fixed
  6. I see the translator tip but it does not look like it is being used. Curiously I have used "Tous" but I see "Tout". I guess, this is auto-generated by the control.
  7. There is plenty of space now. Fixed.
fossfreedom commented 11 years ago

yep - thats a better description - I'll uploaded it - it will take up-to half an hour for launchpad to recognise the change and display the new string for translation.

"All" actually comes from rhythmbox - I presume that clicking "Tous/Tout" in the quick artist filter actually displays all covers for all artists?

jrbastien commented 11 years ago

Yes, Clicking "Tout" displays all covers for all artist. We can live with this small issue. But I assume that the translation is useless.

One last comment about the translation. The different flow modes are not translated. This is not a big issue because I honestly don't know how I would translate them into French but some other languages might require a translation.

fossfreedom commented 11 years ago

no - I cant hide the "All" from the autogenerate translation mechanism - but the code still needs the flag that says "use the translated version of All". Anyway, good that it works.

Re the second issue - Do you mean that the labels of the view buttons (Tiles & Flow) are not displayed in their translated forms?

fossfreedom commented 11 years ago

oh - ok - understand. No, these flow names are the actual names used by the content flow plugins. I'm not sure I would want these translated anyway since they are system names - a bit like the icon theme names.

jrbastien commented 11 years ago

Ok, the flow names can remains in English. Not a problem.

Oups, I just noticed while translating on launchpad that "Padding (space) around the cover and its highlight" should rather be "Padding (space) around the cover and its shadow" given the option name is "Drop Shadow".

fossfreedom commented 11 years ago

You were correct the first time - the highlight is indeed around the cover. The shadow shrinks the cover but the highlight is still around both.

Since the padding and spacing are underneath "Advanced Options", they are distinct from the shadow section.

jrbastien commented 11 years ago

Alright, I changed it back to highlight in the Launchpad translation.

fossfreedom commented 11 years ago

@mateuswetah

any chance I can call on you (yet again!) to update the pt_BR translation on launchpad for v0.9 of the plugin please?

@londumas

one of your french compatriots has made 20 suggestions - any chance that you can review these please?

mateuswetah commented 11 years ago

I'll do it!

2013/8/24 David Mohammed notifications@github.com

@mateuswetah https://github.com/mateuswetah

any chance I can call on you (yet again!) to update the pt_BR translation on launchpad for v0.9 of the plugin please?

- https://translations.launchpad.net/coverartbrowser/trunk/+pots/coverartbrowser/pt_BR/+translate

@londumas https://github.com/londumas

one of your french compatriots has made 20 suggestions - any chance that you can review these please?

- https://translations.launchpad.net/coverartbrowser/trunk/+pots/coverartbrowser/fr/+translate

— Reply to this email directly or view it on GitHubhttps://github.com/fossfreedom/coverart-browser/issues/202#issuecomment-23213254 .

Mateus Machado Luna Cursando Graduação em Ciências da Computação na UFG Goiânia Técnico em Eletrônica pelo IFG Goiânia. http://ubuntugk.wordpress.com/ http://www.flickr.com/photos/mateus-ml-wetah/

fossfreedom commented 10 years ago

@mateuswetah - any chance that you can update the pt_BR translation for the upcoming v1.0 release please?

Thanks for any help you can provide.

mateuswetah commented 10 years ago

Yes, I can!

I'm on vacations now, so no problem ;)

2014/1/16 David Mohammed notifications@github.com

@mateuswetah https://github.com/mateuswetah - any chance that you can update the pt_BR translation for the upcoming v1.0 release please?

Thanks for any help you can provide.

— Reply to this email directly or view it on GitHubhttps://github.com/fossfreedom/coverart-browser/issues/202#issuecomment-32470080 .

_Mateus Machado Luna_Cursando Graduação em Ciências da Computação na UFG Goiânia Técnico em Eletrônica pelo IFG Goiânia. http://ubuntugk.wordpress.com/ http://www.flickr.com/photos/mateus-ml-wetah/