search

fossfreedom / coverart-browser

Browse your cover-art albums in Rhythmbox v2.96 - 3.0+
http://xpressubuntu.wordpress.com/
GNU General Public License v3.0
74 stars 19 forks source link

Add "Use favourites" menu option to properties button to reduce complexity #213

Closed fossfreedom closed 11 years ago

fossfreedom commented 11 years ago

Various menu options are duplicated - standard stuff and their favourite counterpart.

This leads to messy looking menus, duplicated/unnecessarily.

Better to have a persistent "Use favourites" checkbox menu option in the properties button (i.e. saves its state between sessions) - thus if checked, relevant menu options takes this setting into account. The menu labels should change to include "favourite" to indicate which mode these options currently do e.g. "Add to Playlist" --> "Add favourites to Playlist"

---> the GioMenu stuff makes this nigh impossible to do so label changing stuff will be left for the future.

jrbastien commented 11 years ago

I'm doing a bit of QA on this new feature. If I understand correctly, all the menu actions will only apply to favorites (song with a rating superior to the threshold defined in the preferences).

So let's start:

  1. Play Album. If I set all songs of an album to 1 star (my threshold is 4), all the album is still played. Don't we want to play only the favorites?
  2. Queue Album. Working fine. Only the favorites are added to queue.
  3. Add to a play list. Only add the favorites as expected but strangely will add an empty line to the context menu.
  4. Now, for the label "Queue and Play Favorites", I had to retrieve this issue to understand the behavior. I suggest using your original wording "Use Favorites only". Technically, no songs are queued when added to a playlist.
  5. Finally, of course a translation string is needed on Launchpad. This is not available yet.

empty_playlist_lines

jrbastien commented 11 years ago

Let me add a 6th observation: when there are no favorite in the album, nothing happens when selecting "Add to queue" or "Add to playlist". This is expected but for the user, there is no feedback. A nice enhancement would be to provide a popup message "There is no favorite to process for this action" (or anything better - I'm trying to come up with a single message to reduce the number of translation).

This would also help to better understand the feature.

fossfreedom commented 11 years ago

observations:

  1. yep that was a bug after the code refactoring. Should be fixed now.
  2. ok
  3. Defaulted to "New Playlist" instead of a blank playlist name
  4. label changed
  5. yep - will do closer to release
  6. message info dialog now displayed if no tracks added.
jrbastien commented 11 years ago

Very good. I have retested all of this and everything is fixed. Thank you.