search

fossfreedom / coverart-browser

Browse your cover-art albums in Rhythmbox v2.96 - 3.0+
http://xpressubuntu.wordpress.com/
GNU General Public License v3.0
74 stars 19 forks source link

coverflow - scrolling flickers with terminal errors #255

Closed fossfreedom closed 10 years ago

fossfreedom commented 10 years ago

Noticed that with the latest changes, coverflow flickers with errors in the terminal:

Traceback (most recent call last):
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_browser/coverart_artistview.py", line 663, in _on_album_added
    self._artist_manager.model.add_album_to_artist(artist, [album])
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_browser/coverart_artistview.py", line 297, in add_album_to_artist
    self.sort() # ensure the added albums are sorted correctly
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_browser/coverart_artistview.py", line 552, in sort
    self.store.set_sort_column_id(*sortSettings)
TypeError: Argument 1 does not allow None as a value

Seems like a scroll event is being fired on each scroll causing a mass update event in artist view

fossfreedom commented 10 years ago

strange - cannot reproduce this. Closing for now