search

fossfreedom / coverart-browser

Browse your cover-art albums in Rhythmbox v2.96 - 3.0+
http://xpressubuntu.wordpress.com/
GNU General Public License v3.0
74 stars 19 forks source link

Artist view - Suggestion to display the enlarged picture in original ratio #256

Closed jrbastien closed 10 years ago

jrbastien commented 10 years ago

Sometimes the artists thumbnails are not perfectly squared and difficult to see because they look squeezed in either directions.

I understand that for the thumbnail, they should remained square for consistency but could you display the enlarged image with its original ratio?

fossfreedom commented 10 years ago

:)

you just caught me just before I'm preparing for the last beta release ...

here you go. Let me know if this is what you envisaged.

jrbastien commented 10 years ago

Unfortunately, this change does not work. The enlarged image no longer displays. I get this error in the terminal:

(rhythmbox:8066): GdkPixbuf-CRITICAL **: gdk_pixbuf_new_from_file_at_scale: assertion 'width > 0 || width == -1' failed

fossfreedom commented 10 years ago

I left some debug stuff in just in-case...

what is the output of 

 rhythmbox -D coverart_artist
fossfreedom commented 10 years ago

ok - just reproduced this - the fix works in rhythmbox 3.0 but not in earlier versions ... let me have a closer look...

fossfreedom commented 10 years ago

@jrbastien - ok the above fix works for me in RB2.97 as well as RB3.0

jrbastien commented 10 years ago

Thank you, this is now working well for me also. And the pictures are much nicer that way!