fossfreedom / coverart-browser

Browse your cover-art albums in Rhythmbox v2.96 - 3.0+
http://xpressubuntu.wordpress.com/
GNU General Public License v3.0
74 stars 19 forks source link

[Wishlist] Let the selected cover follow the played song #278

Closed Julientroploin closed 10 years ago

Julientroploin commented 10 years ago

Currently, when you play music randomly, the view remains fixed: it does not show the album cover that is currently playing. However, if you select the album currently playing, the cursor follows the current track in the tracklist. It would be interesting to follow the reading. To avoid abrupt changes without user action, the ideal would be to have a button in the toolbar in order to focus the view in one click on the album currently playing.

fossfreedom commented 10 years ago

Sounds very similar to the rhythmbox "Jump To Playing Song" feature - you press CTRL+J and the playing song is highlighted in the music library list view.

So - yes, it is certainly possible to tap into the action that is invoked when the user presses CTRL+J and change focus to the currently playing album and expand the tracks view pane if it isnt already so that you can see the playing song.

As to having a toolbar option - this is this issue

This plugin stated that you cannot have a button in the main toolbar (top of the screen toolbar).

So - I'm happy to look into this - but first I need an artist to design the icon for each of the 5 themes available.

I'll put this on the wishlist for the moment - but will be rapidly promoted to v2 if the icons can be designed :)

Julientroploin commented 10 years ago

It would be cool if you can achieve that ! I'm not an artist, but I'll take a moment this week to see if I'm able to make something nice with Inkskape.

Julientroploin commented 10 years ago

I had a moment this afternoon, so I tried to make a dark icon for "Jump to playing". I used the same color and dimensions of your dark properties.png (128x128) : http://pix.toile-libre.org/upload/original/1394399432.png

Is it the type of icon you want ?

fossfreedom commented 10 years ago

pic

pix

yep - that's the correct size. I replaced "arrow_up.png" in the img/dark sub-folder to see how it would look.

The "play" part with the jump seems to be a bit tight - maybe a bit too much detail with the play icon + the jump icon combined?

I dug out the original rhythmbox 0.11 icon here (ubuntu 10.04) to compare

pix - I think its one of the stock gnome icons in /usr/share/icons/gnome

Can I suggest trying to simplify the icon somehow - not sure how though.

Julientroploin commented 10 years ago

I also find it overloaded, but I liked the idea of ​​adding the symbol "play" ... To make it simpler, we can have: jumpto-3

I had that idea too but I don't like the result : path3019

fossfreedom commented 10 years ago

yep - that's much cleaner and fits the existing dark icons very well.

pic

fossfreedom commented 10 years ago

pic

The balance is sort of wrong here - the left hand-side has alot of dark areas - but the right-hand-side as very little.

However the "bounce" part of the icon is very nice and balances the shape compared to the first icon - maybe an oval or circle would be better than the triangle.

jrbastien commented 10 years ago

Yep, the circle design is nicer. Notice that if you plan to use the icon bar for this feature, you would need a toggle button icon to indicate the option is being selected. Perhaps, it could simply be a properties option under the "Tool" icon.

Julientroploin commented 10 years ago

jrbastien is right : it could simply be an option the "tool" ("Propriétés" in french) menu.

If you choose to include the icon, here is an other variant : the second-icon arrow in the first-icon shape jumpto5

In the second-icon, the triangle was here to recall the play button, but this is not really eye-candy...

I think the best is to wait for the decision "icon or option" before making the icons for other themes. How I can transmit the original svg to make it available if someone want to try modifying it ?

Whatever the decision, I'm OK to make the variants but I'm still pretty busy in the next 10 days, so it will take some time

fossfreedom commented 10 years ago

ok, on the master branch I have implemented part of this functionality - pressing CTRL+J (i.e. the jump to playing shortcut) will scroll and highlight the album that the playing song is in.

What we are talking about in this thread issue is adding a button in the plugin toolbar which does the same as CTRL+J - but adding to this functionality - will scroll the view automatically if another song from another album is playing. Please correct me if I'm overthinking this.

The last icon above looks good and I'm happy to implement such a button. An option via the properties button is perhaps not very obvious.

If you dropbox or use something similar to add a link to the svg file here then others can use it.

fossfreedom commented 10 years ago

ok - I've implemented this via a properties menu option. Thanks