whilst implementing #289 its become obvious that the entryview code is somewhat messy and the code needs refactoring.
There are a few self.variables in coverart_browser_source held for the entry view together with specific entryview type methods.
This together with coverart_entryview leaves a mixed up code and thus is not as easy to maintain as it should be.
Coverart_entry_view should be the key module here. Methods should be created here moving code from coverart_browser_source. Where interactions between coverart_browser_source and coverart_entry_view is needed then either methods or signals as appropriate needs to be made.
Lets call the main new module "entry_view_controller" - so similar to the other controllers. Initialised with the source, this controller manages the ResultsGrid the two entry_view types (compact, full) as well as the toggle button and rating stars.
make this a wish list item for the moment as a reminder this needs to be done
whilst implementing #289 its become obvious that the entryview code is somewhat messy and the code needs refactoring.
There are a few self.variables in coverart_browser_source held for the entry view together with specific entryview type methods.
This together with coverart_entryview leaves a mixed up code and thus is not as easy to maintain as it should be.
Coverart_entry_view should be the key module here. Methods should be created here moving code from coverart_browser_source. Where interactions between coverart_browser_source and coverart_entry_view is needed then either methods or signals as appropriate needs to be made.
Lets call the main new module "entry_view_controller" - so similar to the other controllers. Initialised with the source, this controller manages the ResultsGrid the two entry_view types (compact, full) as well as the toggle button and rating stars.
make this a wish list item for the moment as a reminder this needs to be done