fossfreedom / coverart-browser

Browse your cover-art albums in Rhythmbox v2.96 - 3.0+
http://xpressubuntu.wordpress.com/
GNU General Public License v3.0
74 stars 19 forks source link

Quick Artist list filter displayed by default? #298

Closed jrbastien closed 10 years ago

jrbastien commented 10 years ago

Strangely enough on one of my two system, I have an artist list that is showing at the left of the screen. I know that I can hide it by draging the pane completely to the left but is it by design? This list does not show on my other system. I know we use to have this list to be displayed on choosing an option that is no longer there.

Can we make this option more obivous?

capture du 2014-06-03 21 40 21

jrbastien commented 10 years ago

It seems that no matter what I do, this list comes back when I restart RB.

fossfreedom commented 10 years ago

the closure of the left and right side panes when they get to a small size was deliberate.

You can reopen the panes by dragging from left to right (or right to left for the right pane).

EDIT: maybe can change the pane-handle colour?? something like this but via enforced CSS styling - http://askubuntu.com/questions/86470/how-to-theme-nautilus-resize-area-handle-border and this http://stackoverflow.com/questions/11927785/how-to-make-buttons-different-colours-in-python-gtk3-using-gi

I removed the properties menu option because I felt it was superfluous to this left-right / right-left dragging options to reopen the pane.

The list reappearing on restart though is not normal - it should remember the last position - i.e. whether closed or not. Need to look at this - I'll have some more questions later.

jrbastien commented 10 years ago

Please note that the artist list also re-appears when switching views.

fossfreedom commented 10 years ago

Hi,

please can you run dconf-editor (install it if you havent already - sudo apt-get install dconf-editor) and navigate down the displayed tree to org.gnome.rhythmbox.plugins.coverart_browser

Two fields on the right hand pane should contain some values: artist-info-paned-pos and artist-paned-pos. double click and then highlight the field - ctrl + C to copy

What I need to know is the following:

  1. current values of those two fields
  2. close the artist info pane - what are the values of the two fields when closed.
  3. shutdown rhythmbox - what are the values of the two fields after closure
  4. restart rhythmbox and click coverart - what are the values of the two fields on a restart.

Thanks.

jrbastien commented 10 years ago

The values are all the same in the 4 states you asked me to verify:

artist-info-paned-pos=['artistview:250', 'coverflowview:0', 'coverview:0']
artist-paned-pos=['artistview:0', 'coverflowview:150', 'coverview:94']

I even shutdown dconf to make sure it was refreshing.

fossfreedom commented 10 years ago

that's a very interesting observation.

There must be an error during execution - I'm hoping its displayed when running rhythmbox in debug mode:

rhythmbox -D coverart &> output.txt

then can you dropbox or use paste.ubuntu.com with the contents of the file output.txt

jrbastien commented 10 years ago

1 & 2: http://paste.ubuntu.com/7601211/ 3 & 4: http://paste.ubuntu.com/7601215/

EDIT: I noticed that if I extend the artist pane, it retains the position. It seems that it is lost when I shrink under a specific size.

fossfreedom commented 10 years ago

ok - I note the last EDIT. Yes - the auto shrink (automatic closure) of the artist pane was deliberate - I've coded it to auto-shrink when the pane width is less than 80 pixels. There isnt anything useful you can see below that size, so it closes.

From you last traces I cannot see why on startup the artist pane starts up in an open position when previously you had closed it. Thus, the last commit I've added more debugging information I'm hoping will let me know what is happening when you are moving the artist pane handle

Thus,

  1. first start rhythmbox - ensure the artist pane is open.
  2. close rhythmbox
  3. start rhythmbox via rhythmbox -D coverart &> output.txt
  4. Make the artist pane larger
  5. close rhythmbox and paste.ubuntu.com the output.txt file
  6. start rhythmbox via rhythmbox -D coverart &> output.txt
  7. make the artist pane slightly smaller but not enough to close it
  8. make the artist pane less than 80 pixel - it should automatically close
  9. close rhythmbox and paste.ubuntu.com the output.txt file
  10. start rhythmbox via rhythmbox -D coverart &> output.txt
  11. The artist pane you said starts in the open position ... dont touch the artist pane, just close rhythmbox again
  12. paste.ubuntu.com the output.txt file

Thanks - hopefully the above will give me enough information about to what is going on.

jrbastien commented 10 years ago

In my edited comment I did not mean it was automatically closing. I meant that if I enlarge the list pane enough, it saves the width for the next restart otherwise if I shrink it below 80 pixels (I guess), it does not save the width.

jrbastien commented 10 years ago

3, 4 and 5: http://paste.ubuntu.com/7607740/ 6, 7, 8 and 9: http://paste.ubuntu.com/7607746/ -- the artist pane do not close 10, 11 and 12: http://paste.ubuntu.com/7607751/

Thanks a lot for all your efforts.

fossfreedom commented 10 years ago

thanks - think I see the issue. I've made a small tweak - can you see if it resolves your issue.

If it doesnt please can you repeat 6, 7, 8 and 9 again and paste.ubuntu.com the trace. Thanks.

jrbastien commented 10 years ago

Thank you. It's now working.

jrbastien commented 10 years ago

Looks like we let one through: In the artist pane, when clicking on the artist name to expand the tree, it brings back the side artist list.