jrbastien commented 10 years ago

If I filter for any specific genre then choose "All Genres", no covers are displayed anymore.

I have seen this before. I guess it has to do with my non English system. Normally I would expect to see this string translated so I think something has changed in this function.

fossfreedom commented 10 years ago

cheers for the feedback - I'll switch my system to French Canadian to investigate.

fossfreedom commented 10 years ago

Noticed the following error after the last commit when playing an album - need to resolve this...

"item = self.get_menuitems()[self._controller.get_current_key_index()] File "/home/dad/.local/share/rhythmbox/plugins/coverart_browser/coverart_controllers.py", line 62, in get_current_key_index return self.options.index(self.current_key) ValueError: 'Tous les genres' is not in list"

jrbastien commented 10 years ago

Ok, that's not working and the translated string is back.

jrbastien commented 10 years ago

Not sure is this is related to this change but it does not reload the icon for the custom genre now if it is not defined.

For instance, if I filter for soundtrack, I get the film roll icon. Then if I filter for "Québécois" for which I haven't assigned a custom icon, instead of getting the greyed out head set, it remains on on the film roll icon.

fossfreedom commented 10 years ago

hmm - another one I cannot reproduce - "Québécois" returns the greyed out head-set for me.

if you run rhythmbox with tracing enabled, please can you post the trace - hoping there is some error that I'm not seeing.

jrbastien commented 10 years ago

paste.ubuntu.com seems down. I have uploaded the log here: http://justpaste.it/fux9

I basically start RB in tiles mode, then choose Québécois, then blues then Québécois again. The icon remains the one for the blues.

fossfreedom commented 10 years ago

ok - definitely a bug - I see the error. I'm going to need to the contents of the following directory

~/.cache/rhythmbox/coverart_browser

tar -cvf coverart_cache.tar ~/.cache/rhythmbox/coverart_browser

this will create a tar file with the contents for that folder - you'll see a lot of output wiz by - those are the files it is tar'ing.

If you can drop-box these then it'll give me (hopefully) the same setup as your computer.

fossfreedom commented 10 years ago

@jrbastien - I've reproduce this in this way ...

question - your installation and cleanup routine - do you delete the following folder?

~/.cache/rhythmbox/cb_genre

If you do remove the above folder - but do not delete the corresponding user genres folder ~/.cache/rhythmbox/coverart/usericons then there is a mis-match - the plugin tries to load the genre icon because the popups.xml in ~/.cache/rhythmbox/coverart/usericons says there is a user-defined icon - but it doesnt really exist.

your cleanup routine needs to delete both folders.

jrbastien commented 10 years ago

You are right about my cleanup routine. However adding a remove of ~/.cache/rhythmbox/coverart/usericons does not fix the issue.

This is the script I have created and enhanced over the last year of testing:

!/bin/bash

sudo rm -rf ~/.local/share/rhythmbox/plugins/coverart_browser rm -rf ~/.cache/rhythmbox/cb_genre rm ~/.cache/rhythmbox/coverart/usericons # uncomment when in trouble! # gsettings reset-recursively org.gnome.rhythmbox.plugins.coverart_browser cd /home/jrbastien/Téléchargements rm -rf coverart-browser git clone https://github.com/fossfreedom/coverart-browser.git -b master cd coverart-browser ./install.sh echo "Appuyer la touche <Entrée> pour continuer..." read touche case $touche in *) echo "Reprise du script..." ;;

I have the issue on both of my Ubuntu system (English and French). Given this script did not change and everything was working fine I'm more suspecting one of the commit after June 8th to have contributed to the problem.

The requested tar file can be found here: https://www.dropbox.com/s/5zpbvygpvnhd1rs/coverart_cache.tar

fossfreedom commented 10 years ago

rm ~/.cache/rhythmbox/coverart/usericons

that is a folder - popups.xml is a file within that folder

rm -rf ~/.cache/rhythmbox/coverart/usericons

that should do it.

jrbastien commented 10 years ago

OK, I figured it out. The path is in reality ~/.cache/rhythmbox/coverart_browser/usericons.

That did fix the problem. Notice that the reloading of the cover still persists upon showing the preference screen. Is this wanted?

fossfreedom commented 10 years ago

was a little sleepy when typing that above - sorry :)

Think the cover reloading was always there - lets raise a bug-report anyway.

fossfreedom / coverart-browser

No cover displayed under "All Genres" after filtering for a specific genre #303

!/bin/bash