search

fossfreedom / coverart-browser

Browse your cover-art albums in Rhythmbox v2.96 - 3.0+
http://xpressubuntu.wordpress.com/
GNU General Public License v3.0
74 stars 19 forks source link

Artist info tab images enhancements #317

Closed jrbastien closed 10 years ago

jrbastien commented 10 years ago

It is a rainy holiday here and I have been looking for some new challenges...

Could the Artist info tab images be themed? Or at least be standardized? Currently, the last icon is bearly readable.

image

What do they correspond to exactly? Here is my interpretation:

Here is a proposal:

artist_info

fossfreedom commented 10 years ago

hi there,

everything is possible :)

The first icon is the information about the chosen artist from lastfm the second icon is the information about the chosen album from lastfm the last icon is various information about the artist & album from echonest

Currently the first icon is img/microphone.png the second is img/covermgr.png the third is img/echonest_minilogo.gif

If you look at the source file coverart_artistinfo.py you can search for (for example) "echonest_minilogo.gif" and change the string to the name of the image file you wish to see ... or just overwrite those img/[files]

I can make those themeable very easily ... but obviously every theme folder will need three extra image files.

jrbastien commented 10 years ago

It is not ready for prime time yet but I would like to get some feedback and given you are my only critic (I'm being sarcastic here. You accept pretty much all my designs good or bad!), here is what I have so far:

selection_002

This results in this:

selection_004

The last.fm logo might be a bit difficult to see at that size. I also thought this would introduce too many new colors, so I tried a different design which is a compromise between dark and light theme:

selection_003

The result looks like this:

selection_005

I can't get these ones to be sharp (the pixel snapping issue I have previously explained). I was thinking of perhaps removing the circles and making them larger to use almost all of the 20 pixels I'm given.

Any suggestions, preferences, ideas? It can also stay as it is right now for this version if you prefer.

fossfreedom commented 10 years ago

I like the idea of the last set.

The "i" is a little offset to the right in the circle though.

I wouldnt worry trying to force the lastfm logo into the icons - it is prominently displayed at the bottom of the pane

Personally I like the original "microphone" and "CD" cover design you gave. The echonest logo is excellent - but the blue looks a little out of place given the other two icons are grey. Maybe have the "blue" in a darker grey from the rest of the design?