search

fossfreedom / coverart-browser

Browse your cover-art albums in Rhythmbox v2.96 - 3.0+
http://xpressubuntu.wordpress.com/
GNU General Public License v3.0
74 stars 19 forks source link

Browsing covers "hijacks" playback when playing from the lib #370

Open apnegrao opened 9 years ago

apnegrao commented 9 years ago

I'm not sure if this is a problem or a design choice, but I figured I should let you know any way: if I have something playing from the Library (or any other source, for that matter) and then go to Coverart and click on a cover, when the playing song ends, rhythmbox starts playing the selected cover. This affects only versions of the plugin after the fix for issue #368.

Steps to reproduce: 1 - Start playing from the Library; 2 - Go to Coverart and select any cover; 3 - Click the "Next" button in the toolbar.

The reason is that the Coverart source is being set as the playing source as soon as a cover is selected (i.e., clicked on), rather than when it is selected to play (by double clicking, for example).

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26598846-browsing-covers-hijacks-playback-when-playing-from-the-lib?utm_campaign=plugin&utm_content=tracker%2F351726&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F351726&utm_medium=issues&utm_source=github).
fossfreedom commented 9 years ago

I'll have a look - this has been in place for quite some-time so will need careful testing etc.

Thanks for the report.

fossfreedom commented 9 years ago

think the above commit fixes this - its on the artisticonview branch.

This needs more testing before I'm happy to close this + it hasnt been merged to master yet since I havent completed the main purpose of this branch which is to revamp the artist view.

fossfreedom commented 9 years ago

... also I note that RBNowPlaying seems to work very well now with coverart. Happy :)