fossfreedom / coverart-browser

Browse your cover-art albums in Rhythmbox v2.96 - 3.0+
http://xpressubuntu.wordpress.com/
GNU General Public License v3.0
74 stars 19 forks source link

missing webkit dependency on 16.04 #383

Closed fossfreedom closed 8 years ago

fossfreedom commented 8 years ago

gir1.2-webkit-3.0 is missing from the dependency list

This SHOULD NOT be added though since webkit is security vulnerable but more importantly causes rhythmbox to crash when activated #382

Need to disable sections of code that depend on webkit.

Also - GTK3.18 has changed how size-allocate functions work causing stuff to not space correctly.

DragoonZ commented 8 years ago

I installed gir1.2-webkit-3.0 and it's still crashing

fossfreedom commented 8 years ago

@DragoonZ - as I said above ... it SHOULD NOT be installed.

I've created a new branch (commit) about that resolves the immediate crash.

However, as I said above GTK3.18 has broken the plugin - there are size-allocation issues when running that needs to be fixed.

fossfreedom commented 8 years ago

fundamentally gtk3.18 broke the plugin - closing similar issues and consolidating as this https://github.com/fossfreedom/coverart-browser/issues/387