search

fossfreedom / rhythmweb

rhythmbox v2.9x/v3.x GTK3 port of the original rhythmweb GTK2 plugin created previously for rhythmbox v0.1x
GNU General Public License v3.0
23 stars 8 forks source link

Ability to select which track in playlist or play queue is playing #9

Closed dinoboy197 closed 12 years ago

dinoboy197 commented 12 years ago

Changes:

1) Allow a user to see the tracks in the current playlist if they are playing from a playlist rather than the play queue. 2) User can change to a specific track in the track list by double clicking on it. 3) Track list is zebra-striped, with the currently playing track highlighted.

Please let me know if you have any comments or if something seems not correct here!

dinoboy197 commented 12 years ago

Just a clarification for point 1) - the current functionality of the track list showing the play queue if the play queue is currently playing is unchanged. The functional addition I made is that if the user is playing a track from a playlist (not the play queue) then the tracks from the playlist are shown, rather than the list showing up empty.

fossfreedom commented 12 years ago

cheers.

There seem to be a small issue with the first play of a song - got a server error because self.uri was not defined at this point. Once playing self.uri was then defined through the playing function.

I fixed the crash with a try - except statement.

https://github.com/fossfreedom/rhythmweb/commit/160a1410d8c5e64a9c568a9ef2f9527e3a76e899

fossfreedom commented 12 years ago

As an aside - I tried this on another Ubuntu - it works great.

I also tried this on safari (IPOD) - this displays ok and the buttons work. However the selection doesnt work. I dont have access to any other browser (e.g. chrome / midori) etc so dont know if this is a safari restriction.

Any thoughts?

dinoboy197 commented 12 years ago

Let me do some further testing on my other machines I have laying around. I've got a couple of Macs and Wintel boxes with varying OS versions, so I can try out things on Firefox, Safari, Chrome, IE, etc.

fossfreedom commented 12 years ago

raised issue #11 to track this.