fossgis-routing-server / cbf-routing-profiles

Experimental routing profiles for OSRM.
11 stars 6 forks source link

Don't route on proposed ways #15

Closed lliehu closed 1 year ago

lliehu commented 1 year ago

Routing on proposed ways was blacklisted only for car profile. This adds the same blacklisting also for foot and bike profiles.

It looks like this behavior was added in https://github.com/Project-OSRM/osrm-backend/pull/4258 and then accidentally reverted when pull request at https://github.com/Project-OSRM/osrm-backend/pull/4072 was merged. This commit restores the original change for bike and foot profiles.

There is also an open pull request on the upstream osrm-backend repository: https://github.com/Project-OSRM/osrm-backend/pull/6615

It includes automated tests for these cases and references a GitHub issue that has more background information.

lliehu commented 1 year ago

The pull request in upstream was just merged. It would be nice to have this fix also in this repository and on openstreetmap.org.

datendelphin commented 1 year ago

Sorry, my todo list is too long at the moment. But I should prioritize things when someone is actually doing work for me :) Should show up in a few days on the server

lliehu commented 1 year ago

It's understandable. Thanks!