search

fossgis-routing-server / cbf-routing-profiles

Experimental routing profiles for OSRM.
11 stars 6 forks source link

allow barrier=kerb #2

Open datendelphin opened 4 years ago

datendelphin commented 4 years ago

see https://lists.openstreetmap.org/pipermail/talk-gb/2019-December/023920.html kerb should be whitelisted, maybe a bit penalized

Woazboat commented 3 years ago

Hi, please allow routing over kerbs for bicycles (this has already been fixed in the upstream osrm routing profiles by changing to a less restrictive blacklist instead).

Kerbs are extensively mapped in my area and blocking on kerbs makes major cycling routes unroutable because they include crossings with kerbs.

Example with silly routing: Screenshot_20210625_154952

datendelphin commented 3 years ago

You can make a pull request or wait until someone else has time for it

Woazboat commented 3 years ago

What exactly is the reason for not simply using the upstream osrm profiles?

datendelphin commented 3 years ago

The server got its own profiles because the cycling and walking profiles in the osrm-backend repository were back then inexistent or too crude.

matkoniecz commented 3 years ago

So PR simply replacing them by the current - AFAIK much better - one would be acceptable way of resolving this issue?

Woazboat commented 3 years ago

I simply added kerb to the bicycle barrier whitelist for now (along with some other barrier types): https://github.com/fossgis-routing-server/cbf-routing-profiles/pull/7

datendelphin commented 3 years ago

@matkoniecz I don't think the two profiles are that far removed. And they both have some plus points. The profile here has for example the advantage, that it separates duration and weight, which I think is quite important. So I would rather merge them.

I am not satisfied by how either of them handles barriers. At least a penalty should be added depending on the barrier. The current state seems to largely ignore barriers, unless bicycle=no is explicitly tagged. Even more in the bicycle.lua from osrm-backend which seems to always have had a black list only (The barrier=kerb was an issue for the car profile which got recently fixed in the car profile only)