search

fosshostorg / aarch64

Dashboard and API for https://console.aarch64.com
https://console.aarch64.com
GNU Affero General Public License v3.0
12 stars 7 forks source link

Add debugging/development utils #72

Closed iojcde closed 2 years ago

iojcde commented 3 years ago

This PR adds:

CORS bypass proxy for development - powered by nginx (in docker),

proxies /api to https://console.aarch64.com/api

natesales commented 3 years ago

This is way overkill in my opinion. We shouldn't bundle certificates or a nginx config purely for development. @hamptonmoore thoughts?

iojcde commented 3 years ago

@natesales These are just dummy selfsigned certs, I could remove them if needed.

haylinmoore commented 3 years ago

Hey! Thank you for the PR. This is a very interesting addition I’ve been meaning to do something like for a while. I agree with Nate and don’t think we should be committing keys even if they are just self signed dummies for this, maybe have them generated. It also doesn’t make much sense to have this compose if it doesn’t also launch docker and possibly even run the API & frontend? Those could all be mounted with volumes such that somebody can keep developing. I also would like to see the package lock uncommitted as you didn’t add any new NPM modules so it doesn’t make sense why it changed so much.

haylinmoore commented 2 years ago

Deprecated by recent docker work. Still interested in generation of self-signed certs to provide HTTPS access though