fossilfuelregistry / portal

3 stars 0 forks source link

Annual Emissions Data Screen #163

Open OpenOilUG opened 1 year ago

OpenOilUG commented 1 year ago

Image

OpenOilUG commented 1 year ago

1 - Combustion and pre-Combustion labels are swapped with each other. 2 - Combustion and pre-Combustion labels are swppaed with each other. 3 - Download button does not work 4 - Link to source data is dead 5 - Country name should be repeated

OpenOilUG commented 1 year ago

Information icons correspond to newly created entries in POEditor.

OlegKozlovskui commented 1 year ago

@OpenOilUG status for today: 1,2,4,5 - done 3 - button was hidden for now

OpenOilUG commented 1 year ago

@OlegKozlovskui labels not attached to information icons. 6 - As per discussion, Total Emissions at start should have date range from the data in the following boxes. 7 - If there is no fossil fuel, find a way to stop the placeholder graphic. In Saudi Arabia for example, where there is no coal, the coal production icon keeps spinning forever... https://fossilfuelregistry-v2-kb3l6.ondigitalocean.app/country/sa Best if icon does not appear at all.

Image

OpenOilUG commented 1 year ago

Image

Image

Image

Image

Image

Image

Image

OpenOilUG commented 1 year ago

@OlegKozlovskui

  1. All Coal pre-combustion is displaying as 0 in the ring graphic
  2. Information labels not attached to the legend for the ring
  3. gb for some reason consistently throws client-side exception message (but not other countries)
  4. same as 1
  5. mx - Pre-combustion quantity is higher than combustion which never happens. Also on https://fossilfuelregistry-v2-kb3l6.ondigitalocean.app/country/sa but here the proportions make it look like the two are simply confused one for the other, whereas in Mexico they are so close to each other it does not look right.
  6. The numbers on the ring do not add up to the total in the middle (they are about 410 vs 446)
  7. Same as 6 - the numbers on each of the segments in the ring do not add up to the total. Also: they cannot combine to match the WA points in the chart on the right. Oil pre-combustion + gas pre-combustion should equal the WA on the Pre-combustion in the graphic on the right but they are much lower. Similar oil combustion + gas combustion are 160 - much higher than the WA for combustion in the graph on the right. So although the total is the same in the graph on the right, the components are not.
  8. (not marked on graphic) - the P5-P95 information icon is hooked to the explanation of the range but not the Weighted Average dotted line (which has the entry WA in POEditor)
OlegKozlovskui commented 1 year ago

@niklaserik pls take a look at 5 and 8

OpenOilUG commented 1 year ago

@OlegKozlovskui @niklaserik just checked and it looks like of 8 points above only 2. is now solved, all others still showing. Also, item 7 from previous list - the coal icon still spins forever if there is no coal.

niklaserik commented 1 year ago

Number 8 is now solved

niklaserik commented 1 year ago

Country snapshot infinite spinner on empty values is now fixed (https://github.com/fossilfuelregistry/portal/issues/163#issuecomment-1245143360)

niklaserik commented 1 year ago

6 and 7 are hopefully fixed (https://github.com/fossilfuelregistry/portal/issues/163#issuecomment-1245636596)