search

fosskers / aura

A multilingual package manager for Arch Linux and the AUR.
https://fosskers.github.io/aura/
GNU General Public License v3.0
1.74k stars 114 forks source link

Aura not downloading patch files? #929

Closed FlynnD273 closed 3 days ago

FlynnD273 commented 1 week ago

Trying tp upgrade the extension-manager package for GNOME. It worked for 0.5.1-4, but not the most recent version 0.5.1-5. Here's the output from Aura:

~ ❱ aura -A extension-manager
aura :: Determining dependencies...
aura :: AUR packages:
 extension-manager
aura :: Proceed? [Y/n]
aura :: Preparing build directories...
aura :: Building extension-manager...
==> Making package: extension-manager 0.5.1-5 (Mon 09 Sep 2024 03:56:57 PM EDT)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Found extension-manager-0.5.1.tar.gz
==> ERROR: backtrace.patch was not found in the build directory and is not a URL.
aura :: Package failed to build, citing:

  makepkg failed.

aura :: Action cancelled.

I'm not entirely sure how Aura works under the hood, but it seems like it's only downloading the tarball from the URL in the PKGBUILD, and not the other files in the AUR entry? When I look in the ~/.cache/aura/builds/extension-manager directory I only see the PKGBUILD file, not *.patch files. The patch files are present if I clone/download the package directly from the AUR page though. Is this expected behaviour? I see no mention of it in the documentation so I'm a wee bit confused.

fosskers commented 1 week ago

Can you check the difference in folder contents of ~/.cache/aura/packages/extension-manager/ and ~/.cache/aura/builds/extension-manager/?

FlynnD273 commented 1 week ago

The packages folder has all the expected files, the builds does not. It successfully built and installed after I copied the patch files from packages to builds

fosskers commented 1 week ago

There must be a problem with copying over the .patch files. I'll take a look. Thanks for reporting this.

fosskers commented 3 days ago

I have investigated the issue, and I believe this is a case of the package being improperly packaged. See https://aur.archlinux.org/packages/extension-manager#comment-990684 .

Aura does copy over .patch files, provided that they're properly mentioned in the source list of the PKGBUILD.