search

fosskers / microlens-aeson

Lenses and Traversals for Aeson, based on Microlens.
MIT License
14 stars 6 forks source link

GHC 7.8 Compat #3

Closed fosskers closed 5 years ago

fosskers commented 5 years ago

Closes #2

juhp commented 5 years ago

Thanks looks good to me.

I think you can relax the base package lower-bound to 4.6 then it also builds even with ghc-7.6.3. Yay :-)

fosskers commented 5 years ago

Let me double-check that.

fosskers commented 5 years ago

Hm, 7.6 seems to be considered ancient history as far as my build tools are concerned... let's call 7.8 the lower bound :)

juhp commented 5 years ago

I checked before posting my comment...

fosskers commented 5 years ago

Do you need 7.6 support? 7.8 was released Q1 of 2014, which is getting pretty old.

If it's just a matter of bumping the base bound down, then maybe it's not so bad. For me personally though, it's an issue that I can't verify it myself. Getting old compiler / cabal versions without using stack isn't so easy for me for technical / distro reasons.

I suppose though, I can bump the bound down via a Hackage revision and let the Hackage Matrix prove you right ;)

fosskers commented 5 years ago

Bumped via a revision.

fosskers commented 5 years ago

@juhp there you go:

2019-01-01-120728_1918x1078_scrot

juhp commented 5 years ago

Wow, thanks so much!

Ah yes you use stack for your travis, which is very cool though.