search

fosskers / microlens-aeson

Lenses and Traversals for Aeson, based on Microlens.
MIT License
14 stars 6 forks source link

testsuite failing on 32bit arches #5

Closed juhp closed 4 years ago

juhp commented 4 years ago

I haven't investigated but today I discovered that microlens-aeson-2.3.0.4 tests are failing Fedora i686 and armv7hl like this:

:
  Non-primitive Traversals
    : OK
    : OK
    : OK
    : OK
    : FAIL
      test/Test.hs:51:
      expected: [Number 4.0,Number 7.0]
       but got: [Number 7.0,Number 4.0]
    : FAIL
      test/Test.hs:52:
      expected: "{\"a\":40,\"b\":70}"
       but got: "{\"b\":70,\"a\":40}"
    : OK
    : OK
    : OK
    : OK
    : OK
2 out of 33 tests failed (0.00s)

See for example: https://koji.fedoraproject.org/koji/taskinfo?taskID=39485695

fosskers commented 4 years ago

Looks like the same issue as #1 , and lens-aeson seems to have this fixed: https://github.com/lens/lens-aeson/issues/30

iliastsi commented 4 years ago

This affects Debian as well. I fixed it by applying this patch. Please let me know if you want me to provide a PR.

fosskers commented 4 years ago

Yes please!

fosskers commented 4 years ago

Released as 2.3.1.