search

fosslinux / live-bootstrap

Use of a Linux initramfs to fully automate the bootstrapping process
482 stars 32 forks source link

Avoid deleting sources that will be needed in future builds and fix updating checksums with `--update-checksums` #360

Closed eduardosm closed 8 months ago

Googulator commented 8 months ago

FYI, I've also posted a PR with very similar goals (https://github.com/fosslinux/live-bootstrap/pull/361) without noticing this one; in that, I've gotten quite a bit more working. However, commits https://github.com/fosslinux/live-bootstrap/pull/360/commits/22957b89a8a491dc636e795beae10c6adaf5cafc and https://github.com/fosslinux/live-bootstrap/pull/360/commits/ab86370e99858b8d762bbb6efb9f178a10981627 will still be relevant after my work, so please keep this PR around.

fosslinux commented 8 months ago

This PR looks fairly good, thanks for the cleanups. Could you rebase this on master, then I'll take a second look at it?

eduardosm commented 8 months ago

Done. As expected, only the two mentioned commits remain.

Googulator commented 8 months ago

The remaining CI failure is the one fixed by https://github.com/fosslinux/live-bootstrap/commit/9179f4bd013fbd323d11d861a0c15f37a94f8c5b, and should go away when this is merged.

eduardosm commented 8 months ago

Rebased to pick that commit