Improve pseudo-interactive prompts using the early bash

fosslinux / live-bootstrap

Use of a Linux initramfs to fully automate the bootstrapping process

286 stars 26 forks source link

Improve pseudo-interactive prompts using the early bash #433

Closed Googulator closed 5 months ago

Googulator commented 5 months ago

By wrapping $(cat) in an eval, redirections and other advanced syntax can now work in the early prompts. Also, since "set -E" is broken is the early bash, fall back to using "set -e" and an EXIT trap, until we can upgrade to a bash version that already has working "set -E", or perhaps backport it to 2.05b.

Googulator commented 5 months ago

No checksum update needed because of #394

lulcat commented 3 months ago

Dunno. Did this break something then. With root.py -a amd64 -c -t somedir --cores X (some number), I got a erronous checksum:

/usr/bin/checksum-transcriber: FAILED Wanted: 234d061a727502f3ed3252a1767086a09fda04ee509758fc5852a919e994ca20 Received: 74656fa0cdd15992f7eee5797ecc33d7e65eb0e41acd3c6636cae45e5d3ce35d

Not sure if it had to do with this but can someone confirm which one is the right sum to expect?

Note, this might have been more suited at #394 I dunno, but also. Hmm, avoiding evals if possible in such code is always preferrable I thought?

Googulator commented 2 months ago

checksum-transcriber happens well before Bash, so it shouldn't be affected by Bash-related changes

Googulator commented 2 months ago

Also, -a amd64 isn't really supported yet; it's only for development - as such, breakages are likely (e.g. due to stage0 updates)