search

fossology / FOSSologyUI

Repository to hold the new UI framework for FOSSology built with React
https://fossology.github.io/FOSSologyUI/
GNU General Public License v2.0
49 stars 88 forks source link

fix(gh-pages): added the public url #102

Closed Shruti3004 closed 3 years ago

Shruti3004 commented 3 years ago

Description

Currently the blank screen is coming to https://fossology.github.io/FOSSologyUI/

Changes

Added the public url to deploy.yml

GMishx commented 3 years ago

Interesting, I set the PUBLIC_URL to /react and built the package.

Going to http://localhost/react redirect me first to http://localhost/react/. But then gave me this 404. image

Now, if I click on Home or goto anywhere, the location in address bar changes to http://localhost/... but the page loads (since it is a single page application now). image

Will it be possible to fix it here or you wanna do it in a separate PR?

Shruti3004 commented 3 years ago

Interesting, I set the PUBLIC_URL to /react and built the package.

Going to http://localhost/react redirect me first to http://localhost/react/. But then gave me this 404. image

Now, if I click on Home or goto anywhere, the location in address bar changes to http://localhost/... but the page loads (since it is a single page application now). image

Will it be possible to fix it here or you wanna do it in a separate PR?

Yes, @GMishx this is the same problem that we faced for the apache, I found the solution for it and working on it.

Shruti3004 commented 3 years ago

@GMishx I have fixed it in this pr itself, and this also resolves that error in which we are not able to serve it from localhost/react now we can serve it from localhost/react as well.