fossology / FOSSologyUI

Repository to hold the new UI framework for FOSSology built with React
https://fossology.github.io/FOSSologyUI/
GNU General Public License v2.0
49 stars 88 forks source link

Refactor large components #108

Closed sjha2048 closed 2 years ago

sjha2048 commented 3 years ago

Description

There are several components which needs to be refactored/broken into smaller components

DawnArchi01 commented 2 years ago

Hey @sjha2048 , I would like to know more on the issue .

Raunakk02 commented 2 years ago

Hi @sjha2048 @Shruti3004, If no one's working on this issue then can I take this up? There are many open issues on this repo and many people have already commented for taking up the issues. But as of now, those requests are pretty old and still, no one has been assigned to the issue. So please let me know if the project is still accepting contributors.

mcjaeger commented 2 years ago

hi @Raunakk02, indeed if there is no working on the issue, your contribution is welcome. Please keep in mind that refactoring can be difficult to describe, maybe that way a reason for @sjha2048 to hesitate answering.

Raunakk02 commented 2 years ago

Thanks for the response @mcjaeger. Really appreciate it! I will start working on this issue now.

sjha2048 commented 2 years ago

Hi @Raunakk02, sorry somehow I missed your reply.

feel free to take up this issue and reach out to me in case of any issues/discussions, for now, I'll assign this to you.

mcjaeger commented 2 years ago

Hi, in case you would have the time, maybe consider outlining what your plans are? So we could give feedback and adjust in case. By that approach you re avoiding to work on a PR for a long time alone and then publish something which overlooked one thing in the beginning.

Raunakk02 commented 2 years ago

Sure @mcjaeger, I'll let you know about my plans once I am done outlining them.

Raunakk02 commented 2 years ago

@mcjaeger @sjha2048 Here is the outline of the work that I am planning to do for the PR targeting this issue.

Refactoring outline

Please let me know your views on this.

sjha2048 commented 2 years ago

Hi @Raunakk02 Thank you for the pull request, I'll drop my review soon.