fossology / FOSSologyUI

Repository to hold the new UI framework for FOSSology built with React
https://fossology.github.io/FOSSologyUI/
GNU General Public License v2.0
49 stars 88 forks source link

feat(title): Added the customize title to every page #118

Closed Shruti3004 closed 3 years ago

Shruti3004 commented 3 years ago

Description

In the current implementation, we had the same title FOSSologyUI on the same page but now we have implemented the customize title on every page.

Changes

Screenshots

Screenshot from 2021-07-28 18-08-07 Screenshot from 2021-07-28 18-07-52 Screenshot from 2021-07-28 18-09-53 Screenshot from 2021-07-28 18-15-03 Screenshot from 2021-07-28 18-14-38 Screenshot from 2021-07-28 18-14-17 Screenshot from 2021-07-28 18-13-59

How to test

Visit to all the routes.

GMishx commented 3 years ago

Changes looks good but occasionally I am greeted with this

Failed to compile

src/components/Title/index.jsx
  Line 23:24:  Unable to resolve path to module 'react-helmet'  import/no-unresolved

Search for the keywords to learn more about each error.

This error occurred during the build time and cannot be dismissed.

Any idea? I checked the commit, did yarn install, removed the build folder but after navigating few pages, I get this error both in terminal and browser.

github-actions[bot] commented 3 years ago

This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request.

Shruti3004 commented 3 years ago

@GMishx rebased the pr, I have one doubt as soon I am logging, it logged me out are you facing the same issue?

GMishx commented 3 years ago

@GMishx rebased the pr, I have one doubt as soon I am logging, it logged me out are you facing the same issue?

@Shruti3004 please rebase, should've been fixed by #120

github-actions[bot] commented 3 years ago

This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request.

Shruti3004 commented 3 years ago

@GMishx rebased the pr

GMishx commented 3 years ago

Just missing title for http://localhost:3000/organize/license/create . Other things are working perfectly :+1:

Shruti3004 commented 3 years ago

@GMishx Added the title for create candidate license page.