search

fossology / FOSSologyUI

Repository to hold the new UI framework for FOSSology built with React
https://fossology.github.io/FOSSologyUI/
GNU General Public License v2.0
49 stars 88 forks source link

docs(README.md): rewrote a shell command in a single line. #171

Closed Suman-Jaiswal closed 2 years ago

Suman-Jaiswal commented 2 years ago

Description

rewrote the command "docker build" in a single line. The former was not working.

Changes

from:

docker build \
-t fossologyui:react1.0 \
--build-arg REACT_APP_SERVER_URL="localhost/repo/api/v2" \
--build-arg REACT_APP_HTTPS="false" .

to:

docker build -t fossologyui:react1.0 --build-arg REACT_APP_SERVER_URL="localhost/repo/api/v2" --build-arg REACT_APP_HTTPS="false" .
GMishx commented 2 years ago

Thank you for your contribution @Suman-Jaiswal but this change seems bit unnecessary to me. The command is broken down into lines to ease reading it from readme. However, it works absolutely fine on Linux machines.

Can you please provide some reasons for the proposed change?

GMishx commented 2 years ago

Thanks for your contribution. But the changes seems unnecessary. Please reopen if you have other ideas.