fossology / FOSSologyUI

Repository to hold the new UI framework for FOSSology built with React
https://fossology.github.io/FOSSologyUI/
GNU General Public License v2.0
48 stars 85 forks source link

refactor(api): removed credentials from api request module #209

Closed krishna9304 closed 2 years ago

krishna9304 commented 2 years ago

Issue

This error appears in the console when we navigate to the delete user page.

Screenshot 2022-05-26 at 9 31 55 PM

Description

This PR concerns with the fact that fossology API now doesn't require credentials to work and has been removed from the backend. So, the header needs to be removed from the frontend as well.

Changes

credentials: "includes"

How to test

yarn test

GMishx commented 2 years ago

Please remove the credentials parameter instead of setting to false @krishna9304

krishna9304 commented 2 years ago

Please remove the credentials parameter instead of setting to false @krishna9304

All changes done! PR is updated now.

shaheemazmalmmd commented 2 years ago

@krishna9304 Can you please squash the commits to one.

GMishx commented 2 years ago

Hello @krishna9304 , you can use following commands:

git checkout main
git pull
git checkout krishna9304/update/remove-credentials
git rebase -i main

Then change the pick in front of all commits to squash and close the file. Then please do a force push git push --force-with-lease.

krishna9304 commented 2 years ago

Hello @krishna9304 , you can use following commands:

git checkout main
git pull
git checkout krishna9304/update/remove-credentials
git rebase -i main

Then change the pick in front of all commits to squash and close the file. Then please do a force push git push --force-with-lease.

Sure, will try doing that

krishna9304 commented 2 years ago

Hello @krishna9304 , you can use following commands:

git checkout main
git pull
git checkout krishna9304/update/remove-credentials
git rebase -i main

Then change the pick in front of all commits to squash and close the file. Then please do a force push git push --force-with-lease.

It's done, thank you! :)