fossology / FOSSologyUI

Repository to hold the new UI framework for FOSSology built with React
https://fossology.github.io/FOSSologyUI/
GNU General Public License v2.0
49 stars 87 forks source link

Minimise promise chaining in asynchronous functions (ES6) #216

Open krishna9304 opened 2 years ago

krishna9304 commented 2 years ago

Description

Using “async - await” instead of “.then” wherever possible.

Reason:

It's better to use async/await where possible, and minimise promise chaining. Async/await makes JavaScript code more accessible to developers that aren't as familiar with JavaScript, and much easier to read.]

Example screenshots

Status: Discussion required cc: @Shruti3004 @GMishx @sjha2048

pulkit-30 commented 2 years ago

Hey @krishna9304 @GMishx , I want to work on this issue, May you please tell me what will be the best way to solve or fix this out and also, please assign me this issue. 🚀

krishna9304 commented 2 years ago

Hello @pulkit-30 , As you can see in the example, we want to minimise promise chaining and use async-await wherever possible in the project. Also, make sure to follow the contribution guidelines from https://github.com/fossology/fossology/blob/master/CONTRIBUTING.md before creating a PR.

pulkit-30 commented 2 years ago

Hello @pulkit-30, As you can see in the example, we want to minimize promise chaining and use async-await wherever possible in the project. Also, make sure to follow the contribution guidelines from https://github.com/fossology/fossology/blob/master/CONTRIBUTING.md before creating a PR.

Great, let's do it 🚀

GMishx commented 2 years ago

@krishna9304 @pulkit-30 , one of you want to work on the issue?

krishna9304 commented 2 years ago

if @pulkit-30 is not working on it, i can pick it up!!

pulkit-30 commented 2 years ago

if @pulkit-30 is not working on it, i can pick it up!!

Yep, I am working on this

lata-11 commented 1 year ago

Hi! If this issue is still available, Can I work on it? @GMishx