search

fossology / FOSSologyUI

Repository to hold the new UI framework for FOSSology built with React
https://fossology.github.io/FOSSologyUI/
GNU General Public License v2.0
49 stars 87 forks source link

feat(ui): added delete group page #241

Closed dushimsam closed 2 years ago

dushimsam commented 2 years ago

Signed-off-by: dushimsam dushsam@gmail.com

Description

Added delete group page.

Changes

  1. Added a new file src/pages/Admin/Group/Delete/index.jsx for the UI feature.
  2. Introduced a new route in src/Routes.jsx
  3. Introduced new API callers for the UI integration.
  4. Added a new constant message for successful group deletion.

How to test

  1. Go to the project's main directory.
  2. run command npm start
  3. Visit the page at http://localhost:PORT/admin/group/delete
  4. You are going to see a list of deletable groups which you can select.
  5. Select the group you wish to delete then press Delete button.

delete_group_ui

Related Issue:

Fixes https://github.com/fossology/FOSSologyUI/issues/234

@shaheemazmalmmd @GMishx

dushimsam commented 2 years ago

Done, you may review.

shaheemazmalmmd commented 2 years ago

@dushimsam Can you please fix the testcases ?

dushimsam commented 2 years ago

@dushimsam Can you please fix the testcases ?

sure, it was the problem of incompatible dependency but now they are fixed.

shaheemazmalmmd commented 2 years ago

@dushimsam : Have tested this branch working perfectly. but only issue is after deleting a group page is not getting refreshed. and data still stays in select which might be confusing for user. please make the changes accordingly.

dushimsam commented 2 years ago

@dushimsam : Have tested this branch working perfectly. but only issue is after deleting a group page is not getting refreshed. and data still stays in select which might be confusing for user. please make the changes accordingly.

great , i have added the functionality of reloading the page at every successful delete operation. you may review