feat(UI): Upload permissions page UI and API Implementation done

fossology / FOSSologyUI

Repository to hold the new UI framework for FOSSology built with React

https://fossology.github.io/FOSSologyUI/

GNU General Public License v2.0

47 stars 85 forks source link

feat(UI): Upload permissions page UI and API Implementation done #251

Open krishna9304 opened 2 years ago

krishna9304 commented 2 years ago

Description

Ui and API Implementation of the Upload Permissions page.

Tasks Done

[x] Create the static UI.
[x] Implement data retrieval from html forms.
[x] Implement the new API in PR #2275.
[x] Test everything.

Demo Screenshots

https://user-images.githubusercontent.com/71918441/184526229-9f333dc6-d573-4b57-9171-80d1bfe30163.mp4

How to test

Install the API from -> #2275 in the fossology backend.
In the UI Go to admin>Upload Permissions
The route is available at /admin/upload-permissions

cc: @Shruti3004 @GMishx This closes #247 .

github-actions[bot] commented 2 years ago

This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request.

shaheemazmalmmd commented 2 years ago

@krishna9304 : UI looks good. except that I'm facing issue with adding user to upload who is not first. Page reload every time is causing this can you please check ?

krishna9304 commented 2 years ago

@krishna9304 : UI looks good. except that I'm facing issue with adding user to upload who is not first. Page reload every time is causing this can you please check ?

yes, there are some changes in the backend that's causing this issue. I'll fix this and update the PR.

krishna9304 commented 2 years ago

Fixed the issues and updated the PR. PTAL @shaheemazmalmmd .

krishna9304 commented 2 years ago

resolved conflicts @shaheemazmalmmd .

shaheemazmalmmd commented 2 years ago

@krishna9304 While testing i have found that i was not able to render the groups also the public permissions has been changed to user permission. please not that public permissions here are specific to upload not to user.

krishna9304 commented 2 years ago

@krishna9304 While testing i have found that i was not able to render the groups also the public permissions has been changed to user permission. please not that public permissions here are specific to upload not to user.

Update the PR. PTAL at the recent changes. @shaheemazmalmmd

shaheemazmalmmd commented 2 years ago

@krishna9304 I have tested the Pull request and i still see the same issue.