fossology / FOSSologyUI

Repository to hold the new UI framework for FOSSology built with React
https://fossology.github.io/FOSSologyUI/
GNU General Public License v2.0
47 stars 85 forks source link

UI Bug At the footer #266

Open Ranamalsingh12 opened 1 year ago

Ranamalsingh12 commented 1 year ago

UI Bug

I was checking FossologyUI when i found this bug in footer where the version, branch, build showing [] and commit showing : [#Undefined].

Screenshots

Screenshot from 2022-10-05 20-34-41

Also Can i work on this issue?

hritik2002 commented 1 year ago

@Ranamalsingh12 are you working on the issue?

Ranamalsingh12 commented 1 year ago

Hey @hritik2002 i am working on it currently as you know diwali is going on so i am at currently not working but will start working soon

hritik2002 commented 1 year ago

Okay.

Ranamalsingh12 commented 1 year ago

Hey Shourya i have resolved this issue there is nothing error with the API they made it that way after my PR will accepted this issue will be resolved

On Wed, Nov 16, 2022 at 2:48 AM SHOURYA SHIKHAR @.***> wrote:

@Ranamalsingh12 https://github.com/Ranamalsingh12 please assign me to this. Also I checked the api. Looks like there's an error with the API. Can you please guide me through this?

— Reply to this email directly, view it on GitHub https://github.com/fossology/FOSSologyUI/issues/266#issuecomment-1315875643, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVTNMRIKCDVII2X56E3BBFDWIP4Z3ANCNFSM6AAAAAAQ5VMODA . You are receiving this because you were mentioned.Message ID: @.***>

hussain-shariff commented 1 year ago

@Ranamalsingh12 is this issue closed?

Ranamalsingh12 commented 1 year ago

Yes it's closed I made the PR it's going to merge and this issue will be closed

On Mon, 16 Jan 2023, 19:34 Hussain, @.***> wrote:

@Ranamalsingh12 https://github.com/Ranamalsingh12 is this issue closed?

— Reply to this email directly, view it on GitHub https://github.com/fossology/FOSSologyUI/issues/266#issuecomment-1384111109, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVTNMRMP3QVIRLVLNTQVCDLWSVIQNANCNFSM6AAAAAAQ5VMODA . You are receiving this because you were mentioned.Message ID: @.***>

sahilsekr42 commented 1 year ago

this issue is still present what happened to the PR

sahilsekr42 commented 1 year ago

I believe instead of using "unknown " for comparision undefined had to be used

sahilsekr42 commented 1 year ago

@GMishx @Shruti3004 @shaheemazmalmmd would love to see the PR being merged if it doesn't cause issues . Also I would like to contribute more , hence am open to suggestions....