search

fossology / FOSSologyUI

Repository to hold the new UI framework for FOSSology built with React
https://fossology.github.io/FOSSologyUI/
GNU General Public License v2.0
49 stars 88 forks source link

UI Bug At the footer #271

Open Ranamalsingh12 opened 2 years ago

Ranamalsingh12 commented 2 years ago

Issue

When i forked and clone the fossology UI and the backend on the home page there is nothing in front of the version, branch, commit it just was an empty array at first i thought this was a issue from the backend but when i had a chat with the people from backend they said that they are working on it but also the response will be the same for new user so i change the code and add a ternary operator and now you can know what will be in front of the version, branch and commit.

Please describe the changes in your pull request in few words here.

Changes

I add the change at footer. It works like when a new person first download the backend from the fossology and fossology UI. At home page at the footer there was a ui bug that there is nothing in front of version, Branch, commit i changed the code that for new person which will be having same response from backend fom footer as me i used if else condition (ternary operator) in react to solve that issue.

Please consider using the closing keyword if the pull request is proposed to fix an issue already created in the repository (https://help.github.com/articles/closing-issues-using-keywords/)

dushimsam commented 2 years ago

could you squash those commits into one

Ranamalsingh12 commented 2 years ago

Sure @dushimsam i will do.