fossology / atarashi

Atarashi scans for license statements in open source software, focusing on text statistics. Designed to work stand-alone and with FOSSology.
http://fossology.github.io/atarashi
GNU General Public License v2.0
26 stars 23 forks source link

feat(Atarashi): Added Copyright statements to Atarshi files #28

Closed amanjain97 closed 6 years ago

amanjain97 commented 6 years ago

Added Copyright statement to atarashi files Copyright 2018 Aman Jain

GMishx commented 6 years ago

@ag4ums and @mcjaeger I have a general question here. Is it optional or required to add the email along with author's name in a copyright statement?

mcjaeger commented 6 years ago

I thin it is optional, but ... anything that helps identifying the copyright will be better. In this case: How popular is Aman Jain as a name? Michael Jaeger is a name which is very popular:

https://www.kbs.tu-berlin.de/menue/personen/ehemalige_mitarbeiterinnen/parameter/en/

-> Two "Michael Jaeger" sitting in the same office!

So in case, @amanjain97:

You could consider adding your e-mail

mcjaeger commented 6 years ago

hi, just another question: have you also considered pulling the test files as part of the installation procedure?

GMishx commented 6 years ago

The test files are already the part of the repo. This also remind me one thing @mcjaeger , we do not have a installation script yet. We just run Atarashi from the clone itself. That might be done during the FOSSology integration.

GMishx commented 6 years ago

@amanjain97 , please remove commit f61564d and 09b98f2 from this pull request as they are already in #23