search

fossology / atarashi

Atarashi scans for license statements in open source software, focusing on text statistics. Designed to work stand-alone and with FOSSology.
http://fossology.github.io/atarashi
GNU General Public License v2.0
26 stars 23 forks source link

Run the evaluator command without any 'similarity' parameter #61

Closed hastagAB closed 4 years ago

hastagAB commented 4 years ago

Description

The Evaluator commands are set for both two parameters i.e agent_name and similarity but some agents runs without similarity type also.

Example: for tfidfagent there are three commands :

  1. With cosine similarity : atarashi -a tfidf -s CosineSim /path/to/file.c
  2. With Score similarity : atarashi -a tfidf -s ScoreSim /path/to/file.c
  3. Without any similarity : atarashi -a tfidf /path/to/file.c

The evaluator covers the first two cases and not the third one. The same goes for other agents.

How to fix

  1. Goto the getCommand function of the evaluator
  2. Write separate conditions as desired or manipulate the existing ones.
  3. Test and verify if it's working.
Kaushl2208 commented 4 years ago

Hey, @hastagAB this issue seems nice. Can I work on it?

hastagAB commented 4 years ago

Hey, @hastagAB this issue seems nice. Can I work on it?

Yes Please, Go Ahead! 👍