fossology / atarashi

Atarashi scans for license statements in open source software, focusing on text statistics. Designed to work stand-alone and with FOSSology.
http://fossology.github.io/atarashi
GNU General Public License v2.0
26 stars 23 forks source link

Pipfile: the replacement for requirements.txt #66

Open Kaushl2208 opened 4 years ago

Kaushl2208 commented 4 years ago

We can migrate our current requirement.txt file to pipfile due to several reasons like:

or, Refer: Why?

GMishx commented 4 years ago

That would be a good change. But will it effect the existing pyproject.toml (compatibility with PEP 518)?

Kaushl2208 commented 4 years ago

Yes, It will replace pyproject.toml and it might affect setup.py. Not sure, about it rn.

Can I submit a PR for it?

GMishx commented 4 years ago

Yes, sure @Kaushl2208. Just make sure the current build wheel build should not break because of this change.

lohithmunakala commented 3 years ago

Is this still open @GMishx ? I wanna work on this.

GMishx commented 3 years ago

Yes @lohithmunakala, from my end the issue is still open. @Kaushl2208 do let us know if you are working on the issue.

It will be nice to assign the issue to the person currently working on it.

lohithmunakala commented 3 years ago

If @Kaushl2208 isn't working on it rn, can you help me get started with the issue @GMishx ?

Kaushl2208 commented 3 years ago

Hey @GMishx, We can assign this issue to @lohithmunakala. I don't have the rights to do so.

hastagAB commented 3 years ago

Hey @GMishx, We can assign this issue to @lohithmunakala. I don't have the rights to do so.

Meanwhile @lohithmunakala You can start working on this issue. It will be a great help.

GMishx commented 3 years ago

I have assigned the ticket to you @lohithmunakala .

You can start looking into pipenv documentation: https://pipenv.pypa.io/en/stable/ Expectation from this change is:

  1. Removal of dependencies from requirements.txt and setup.py
  2. Should not break PEP 517 changes (try to build Dockerfile to test)
  3. Clear separation of additional dependencies like csv and json files generated by running python3 setup.py build