Closed SinghShreya05 closed 3 years ago
This is with respect to issue #77. Please review @GMishx
Kindly review it @GMishx
Tried running the code, got following error:
$ atarashi -a Ngram -s BigramCosineSim atarashi/libs/
Traceback (most recent call last):
File "/atarashi/.venv/bin/atarashi", line 33, in <module>
sys.exit(load_entry_point('atarashi', 'console_scripts', 'atarashi')())
File "/atarashi/atarashi/atarashii.py", line 153, in main
for dirpath, dirnames, filenames in os.walk(filepath):
NameError: name 'filepath' is not defined
@SinghShreya05 , since we try to keep our git history clean and this PR adds a single feature (which can not be divided into multiple commits), can you please squash the commits into single commit before we can merge it?
@GMishx I have created a new branch "feat/scandirectory" and sent a new pull request with just one commit. I'm closing this PR.
@SinghShreya05, That's not how this works. He will need to review and test the functionality again. It will cost more time and energy. Try squashing the commits for the PR which is approved.
This is with respect to issue #77. Please review the PR. @hastagAB @Kaushl2208