search

fossology / atarashi

Atarashi scans for license statements in open source software, focusing on text statistics. Designed to work stand-alone and with FOSSology.
http://fossology.github.io/atarashi
GNU General Public License v2.0
26 stars 23 forks source link

feat(DLD): Add native damerauLevenDist agent #91

Closed its-sushant closed 2 years ago

its-sushant commented 2 years ago

feat(DLD): Add native damerauLevenDist agent

Closes #90

GMishx commented 2 years ago

Hello @its-sushant ,

  1. Unfortunately I see no additional benefit compared to https://github.com/gfairchild/pyxDamerauLevenshtein/blob/master/pyxdameraulevenshtein/pyxdameraulevenshtein.pyx . The function even seemed copied which we discourage strongly.
  2. Bringing in the code to atarashi means we have to maintain it. Whereas getting it as a dependency, we do not have to care for it anymore. It is just additional burden in my opinion.
  3. Not a major point but using Cython means additional build time for atarashi, compared to just downloading the wheel from pypi in case of extrnal library.