search

fossology / fossology

FOSSology is an open source license compliance software system and toolkit. As a toolkit you can run license, copyright and export control scans from the command line. As a system, a database and web ui are provided to give you a compliance workflow. License, copyright and export scanners are tools used in the workflow.
https://fossology.github.io/
GNU General Public License v2.0
802 stars 419 forks source link

'Clean Text' button click does not clean texts with character, '*' #2100

Closed rahulmohang closed 2 years ago

rahulmohang commented 3 years ago

Description

The action on 'Clean Text' button does not remove the character, '*', that is very common part of texts.

How to reproduce

  1. Go to Bulk recognition on a file with a license text starting with the '*' character.
  2. Paste the reference text to the 'Reference text' field.
  3. Click the 'Clean Text' button.

Screenshots

If applicable, add screenshots to help explain your problem.

Versions

Logs

Any logs (if any) generated in

FOSSology logs

Logs generated under /var/log/fossology/fossology.log

Apache logs

Logs generated under /var/log/apache2/error.log

Job logs

Logs generated under Geeky Scan Details (Job history => click on agent's job id)

GMishx commented 3 years ago

I though I replied already but there is a PR with more comment identifiers https://github.com/fossology/fossology/pull/2073

rahulmohang commented 3 years ago

ok, thank you. One comment though - Most of the characters are cleaned as of now. As per what I observed, '*' is not.

GMishx commented 3 years ago

Yeah, the PR adds following new symbols to the mix

Also, ability to provide your own list per scan.

rahulmohang commented 3 years ago

Thank you.

teekhandekar commented 2 years ago

@GMishx can I work on this ?

GMishx commented 2 years ago

@rahulmohang , can you please check if the issue is resolved or still exists?

rahulmohang commented 2 years ago

@GMishx , Yes.

rahulmohang commented 2 years ago

I will check.

rahulmohang commented 2 years ago

@GMishx , it is working. Thank you. Please excuse me for the late response. We took some time to set up the new version of Fossology.

GMishx commented 2 years ago

Thanks for confirmation @rahulmohang ,closing the issue.