search

fosspill / FFXIV_Modding_Tool

FFXIV Modding Tool is the Cross-platform Commandline interface alternative for TexTools
https://ffmt.pwd.cat/
GNU General Public License v3.0
47 stars 4 forks source link

[ISSUE] WARNING: Found a mod applied by an unknown application, only using FFMT #202

Closed zeparu closed 4 years ago

zeparu commented 4 years ago

Im using an automated installer script (zsh), to automatically install a bunch of mods that i put in a folder

but sometimes it feels like specific files will trip up the program and it will report that the game has been modified by a different program

Describe the bug -> install "problematic" mod -> install another mod

WARNING: Found a mod applied by an unknown application, game stability cannot be guaranteed: 
Would you like to continue? (y/N)

To Reproduce only certain mods will create this, but one file that consistently works for me is from https://github.com/skotlex/ffxiv-material-ui/releases/tag/3.2.0, in the OPTIONS archive, OPTIONS/04_GaugeBar/04_gaugebar-frame-silver/gaugebar-frame-silver.ttmp2

the ttmp2 probably has some metadata that FFMT is not handling correctly, pasting it into the XivMods.json, and then reading that information

Expected behavior FFMT doesnt recognize itself as an unkown application

Desktop (please complete the following information):

fosspill commented 4 years ago 
{"TTMPVersion":"1.0s","Name":"gaugebar-frame-silver","Author":"skotlex","Version":"1.0.0","Description":null,"ModPackPages":null,"SimpleModsList":[{"Name":"Parameter_Gauge2","Category":"HUD","FullPath":"ui/uld/parameter_gauge2.tex","ModOffset":0,"ModSize":9984,"DatFile":"060000","ModPackEntry":null},{"Name":"parameter_gauge","Category":"UI","FullPath":"ui/uld/parameter_gauge.tex","ModOffset":9984,"ModSize":1177600,"DatFile":"060000","ModPackEntry":null},{"Name":"JobHudSimple_StackB","Category":"HUD","FullPath":"ui/uld/jobhudsimple_stackb.tex","ModOffset":1187584,"ModSize":2048,"DatFile":"060000","ModPackEntry":null},{"Name":"JobHudSimple_StackA","Category":"HUD","FullPath":"ui/uld/jobhudsimple_stacka.tex","ModOffset":1189632,"ModSize":2048,"DatFile":"060000","ModPackEntry":null}]}
fosspill commented 4 years ago

Both @shinnova and I have been unable to reproduce the issue with the modpack you linked, but I have seen the issue before.

Since the "unknown application" is blank in your case it is safe to continue, though.

We'll go through the relevant parts of the code and see where it goes wrong

fosspill commented 4 years ago

This seems to likely be a framework bug. I think the best solution would be to not throw a warning if the unknown application is blank.

shinnova commented 4 years ago

@zeparu Could you test with this version, and give me the output of the debug text of the previous import, if you get the unknown error again? Please reset your game before testing.

zeparu commented 4 years ago 
Validating cache...
Checking backups before proceeding...
All backups present and up to date
Starting import...
Extracting data from gaugebar-frame-silver.ttmp2...
Data extraction successful.
Importing 4/4 mods from modpack...
DEBUG: Modpack name = gaugebar-frame-silver
DEBUG: Modpack author = skotlex
DEBUG: Modpack version = 1.0.0
DEBUG: Modpack url = 
DEBUG: Minimum framework version = 1.0.0.0
DEBUG: Source = FFXIV_Modding_Tool
Waiting for import process to respond...
If percentage doesn't display for a few minutes, wipe your mod_cache.db and try again
100%
4 mod(s) successfully imported.
Updated /home/zepar/.config/FFXIV_Modding_Tool/modlist.cgf to reflect changes.
Validating cache...
Checking backups before proceeding...
All backups present and up to date
WARNING: Found a mod applied by an unknown application, game stability cannot be guaranteed: 
Would you like to continue? (y/N)
y
Starting import...
Extracting data from round-background-job-icon.ttmp2...
Data extraction successful.
Importing 40/40 mods from modpack...
DEBUG: Modpack name = round-background-job-icon
DEBUG: Modpack author = skotlex
DEBUG: Modpack version = 1.0.1
DEBUG: Modpack url = 
DEBUG: Minimum framework version = 1.0.0.0
DEBUG: Source = FFXIV_Modding_Tool
Waiting for import process to respond...
If percentage doesn't display for a few minutes, wipe your mod_cache.db and try again
100%
40 mod(s) successfully imported.
Updated /home/zepar/.config/FFXIV_Modding_Tool/modlist.cgf to reflect changes.
shinnova commented 4 years ago

Thank you, that confirms the suspicion it is an issue in the framework. Our next release will ignore blank source names. Out of curiosity, can you make this happen without the --noproblemcheck?

zeparu commented 4 years ago

yes, on normal release and the test version it still happens without skipping problemcheck