search

fosspill / FFXIV_Modding_Tool

FFXIV Modding Tool is the Cross-platform Commandline interface alternative for TexTools
https://ffmt.pwd.cat/
GNU General Public License v3.0
47 stars 4 forks source link

[ISSUE] Stringing together commands can cause corruption of gamedata #48

Closed fosspill closed 5 years ago

fosspill commented 5 years ago

Describe the bug If you string together multiple commands the gamedata can corrupt.

I presume that this is due to disk activity not being done before starting more activity? This is purely a blind guess.

To Reproduce Steps to reproduce the behavior:

  1. Run command 'textools r && textools mpi -i mymodpack.ttmp2'
  2. Start game, get error about missing datafiles

Expected behavior Running the string of commands should end up with a proper working game.

Desktop (please complete the following information):

Suggestions

  1. Adding a problemcheck after modpack import could potentially help?
  2. Adding a ffttcli_lock file with a unix timestamp in the future before starting imports(starttime + 30min fi) and then updating it to be a few seconds after ended operation (endtime + 2min). The second command would then have to wait for this time to be reached
  3. Adding some kind of disk activity check (wait for disk sync). This would likely be the cleanest way.
shinnova commented 5 years ago

Running the problemcheck after importing a modpack prevents the corruption from happening, so this seems to be a good solution. Will also add a flag that lets a user skip the problemcheck after import if desired.