fossunited / monschool-website

Repository of all courses on mon.school
26 stars 10 forks source link

Add chapters for Mypy Primer #16

Closed tusharsadhwani closed 3 years ago

tusharsadhwani commented 3 years ago

Currently only contains the description, chapter and lesson names.

tusharsadhwani commented 3 years ago

@anandology Can you do a cursory check of whether the yml and md files look fine?

anandology commented 3 years ago

Looks good other than the issue with is_published

anandology commented 3 years ago

I'm worried about the advanced-type-checking chapter. It feels like it is really advanced and might confuse the beginners. @kracekumar could you please review the outline and see if you have suggestions for changes.

tusharsadhwani commented 3 years ago

While the topics themselves can get complex, the typing aspect of decorators and generators isn't that much more complex than, say, typing an iterable, or a function passed to a function. I think I can explain it without it getting too complex.

Context managers, on the other hand, would get too complicated. I'll probably remove that one.

anandology commented 3 years ago

While the topics themselves can get complex, the typing aspect of decorators and generators isn't that much more complex than, say, typing an iterable, or a function passed to a function. I think I can explain it without it getting too complex.

You are going with an assumption that the participants will know what decorators, generators and iterators mean. That may not be true.

My recommendation is to save this chapter for a more advanced course.

Context managers, on the other hand, would get too complicated. I'll probably remove that one.

👍🏽

tusharsadhwani commented 3 years ago

You are going with an assumption that the participants will know what decorators, generators and iterators mean.

There's two reasons here:

tusharsadhwani commented 3 years ago

@anandology PTAL, what's the next step?

anandology commented 3 years ago

Can you suggest an image for the course? I'll add that and publish the course as a preview on mon.school.

tusharsadhwani commented 3 years ago

I like the stock mypy image:

mypy 1
tusharsadhwani commented 3 years ago

Here's the svg https://camo.githubusercontent.com/20e0f72b4f84dc5b42aceb95eb8eaa6c574746c0057e9e2525dd6cb4797d565f/687474703a2f2f6d7970792d6c616e672e6f72672f7374617469632f6d7970795f6c696768742e737667