search

fossunited / monschool-website

Repository of all courses on mon.school
24 stars 10 forks source link

WIP: Building Web App Chapter 1 #35

Open thejeshgn opened 2 years ago

netlify[bot] commented 2 years ago

✔️ Deploy Preview for monschool ready!

🔨 Explore the source changes: 1294b394c5a6eae5d903cab2808480a8a03cb2d8

🔍 Inspect the deploy log: https://app.netlify.com/sites/monschool/deploys/621efa44de9d340008eb493d

😎 Browse the preview: https://deploy-preview-35--monschool.netlify.app

anandology commented 2 years ago

Looks good to me @thejeshgn. I think we can merge this PR and you can raise a new PR for each chapter.

anandology commented 2 years ago

@thejeshgn please rebase against master so that you can see the autopreview.

thejeshgn commented 2 years ago

@anandology done

anandology commented 2 years ago

One suggestion about the How to add a break section.

Just adding
in the example isn't giving a clue of how it works.

My suggestion is to move the How to add a break section after How to make text bold, italized or underlined and add line breaks to the same example.

<strong>Text in bold</strong><br>
<u>Text in underlined</u><br>
<em> - Emphasized text </em>

Also the word break is repeated twice in the title of the How to add a break section. It reads as How to add a break break.