fostorial / Legedit2

10 stars 13 forks source link

QoL: Consider merging some templates together #49

Closed bloodwurm closed 4 years ago

bloodwurm commented 4 years ago

Seeing templates being copied just so small thingies can be changed (like a different background, or a different name). For instance, there's Mastermind, Epic Mastermind, Mastermind Token, Epic Mastermind Token, etc.... which are almost all the same thing but for one little change.

Consider having one template that allows for several different "configs" or choices that make the template change "drastically". For instance, a Token card could probably be implemented through the use of a single check box: Is it a Token card?. Way less of a nightmare than having copied over templates.

Once that's done, it would still be of value to users if, when they would add a card, they were still seeing all the available choices independently, to allow for quick access and making it feel less like you need to dig into so many options to find the one you want.

bloodwurm commented 4 years ago

Implementing through styles could be the way to go for the original post.

Another solution could be to still have different templates for each possible card but instead of having full copies of the template and change one single thing, we could have templates that refer to another template and then change some value. So an "operation" template could refer to the "scheme" template and change the overlay image and the "Scheme" text to "Operation". Being a template it would still appear independently within the app which can be useful to users and being a modifier of a base template would make for way more manageable files.

bloodwurm commented 4 years ago

Templates that seemingly could be simplified:

bloodwurm commented 4 years ago

DONE: Mastermind Epic, Mastermind Epic Token, Mastermind Token, Mastermind Transformed. DONE: Bindings DONE: Corrected the display name for Grevious wound (will now show Grievous Wound). DONE: Scheme Twist and Custom Scheme Twist now based on Master Strike

bloodwurm commented 4 years ago

DONE: Hero cards have been converted and besides the rare cards, all are now based off of the Hero Common template. Here is a small dependency tree: Hero Common Transformed -> Hero Common Hero Uncommon Transformed -> Hero Uncommon -> Hero Common Hero Rare Transformed -> Hero Rare Left Hero Rare alone (for now) since it doesn't have extra elements that Hero Common has...

bloodwurm commented 4 years ago

DONE: Operation now based off of Scheme DONE: Special Sidekick now based off of Hero Common

bloodwurm commented 4 years ago

DONE: Henchmen Location and Backup Adversary now use henchmen.

bloodwurm commented 4 years ago

DONE: Adversary and Villain Transformed now use Villain. DONE: Villain Token cannot be switched because it would break old data.

bloodwurm commented 4 years ago

DONE: Villain Wound now uses Grievous Wound