search

fotosyn / berrycam

Source code and support files for BerryCam - the controller app for the Raspberry Pi camera module
16 stars 2 forks source link

Add logging. Use systemd. #7

Closed jcksnvllxr80 closed 3 years ago

jcksnvllxr80 commented 3 years ago
  1. I updated the README but it could definitely use more love since I refactored the structure of the directory and didn't fine-tooth comb the README.
  2. I moved the python scripts to the place in the build folder (maintaining the script in two places would be a tiny nightmare) where they will go in the system (i.e. /usr/bin/berryCam). I'm not sure how you feel about that but the READMEs suffer because of that refactor and I didn't go back through everything you had already written to fix stuff :/
  3. Maybe this should be a branch called berrycam-service??
fotosyn commented 3 years ago

Thanks for this and apologies for not getting back. I've been a tad under the weather this week and not getting as much screen time as I usually would.

Let me take a look later this week and come back with some suggestions - thinking that we potentially branch this version so that the other route still exists as well as this improved, service based approach. That gives the user a choice to opt for whichever version they are most comfortable with

fotosyn commented 3 years ago

Fantastic work by the way, might be good to pick your brains on how a live streaming version could work with BerryCam.

jcksnvllxr80 commented 3 years ago

Maybe we can avoid branching by putting the BerryCam*.py files in the /home/pi directory and using a link (hard/soft) to also put them in the /usr/bin directory (where the service is running)... this way, only one file needs to be maintained. Also, remove the service enable command from the installation script so it doesn't run on boot out of the gates. If the user wants to enable it to start on boot manually, they can do that with a command... but if not, it still works the same way you already have it setup. I just need to do some testing to see how the link piece will work.